Skip to content

Minor refactor of IndexBackfiller to eliminate private property. #3689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2022
Merged

Minor refactor of IndexBackfiller to eliminate private property. #3689

merged 1 commit into from
May 4, 2022

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Apr 28, 2022 •
edited
Loading

This is a very minor refactor to simplify code:

  • removes 2 lines of code.
  • removes 1 private property.
  • removes conditional evaluation on every execution.
  • removes assignment on every execution.
  • adds 1 parameter to private method.

There should be no side effects, since the IndexBackfiller never appears to start after a being stopped. If for some reason the IndexBackfiller should start again, there will simply be a larger delay in subsequent starts.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 46.21% (672c6dc) to 46.05% (e8fc017) by -0.17%.

    FilenameBase (672c6dc)Merge (e8fc017)Diff
    AsyncQueue.java78.61%78.11%-0.50%
    Datastore.java32.14%29.76%-2.38%
    FirestoreChannel.java18.10%16.38%-1.72%
    FirestoreClient.java38.24%30.88%-7.35%
    GrpcCallProvider.java69.41%62.35%-7.06%
    IndexBackfiller.java92.19%78.69%-13.50%
    LruGarbageCollector.java93.46%84.11%-9.35%
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java97.22%94.44%-2.78%

Test Logs

Notes

  • Commit (e8fc017) is created by Prow via merging PR base commit (672c6dc) and head commit (418cf87).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7twxtmnK51.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (672c6dc)Merge (e8fc017)Diff
    aar1.26 MB1.26 MB-58 B (-0.0%)
    apk (release)3.38 MB3.38 MB+184 B (+0.0%)

Test Logs

Notes

  • Commit (e8fc017) is created by Prow via merging PR base commit (672c6dc) and head commit (418cf87).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/84WcvOS6Kh.html

@tom-andersen
Copy link
Contributor Author

/test device-check-changed

@tom-andersen tom-andersen requested a review from wu-hui April 29, 2022 19:54
@tom-andersen tom-andersen marked this pull request as ready for review April 29, 2022 19:54
wu-hui
wu-hui approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@wu-hui wu-hui assigned tom-andersen and unassigned wu-hui May 4, 2022
@wu-hui wu-hui merged commit 3aaf7ad into master May 4, 2022
@wu-hui wu-hui deleted the tomandersen/simplifyScheduleBackfil branch May 4, 2022 00:47
@firebase firebase locked and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@tom-andersen tom-andersen

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tom-andersen @google-oss-bot @wu-hui