Skip to content

Actually skips overlay migration when run a second time. #3704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2022
Merged

Actually skips overlay migration when run a second time. #3704

merged 3 commits into from
May 9, 2022

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented May 6, 2022

No description provided.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 46.22% (8394f24) to 46.08% (9738d84) by -0.14%.

    FilenameBase (8394f24)Merge (9738d84)Diff
    AsyncQueue.java78.61%78.11%-0.50%
    Datastore.java32.14%29.76%-2.38%
    DeleteMutation.java90.48%95.24%+4.76%
    FirestoreChannel.java18.10%16.38%-1.72%
    FirestoreClient.java38.24%30.88%-7.35%
    GrpcCallProvider.java69.41%62.35%-7.06%
    IndexBackfiller.java93.44%78.69%-14.75%
    LruGarbageCollector.java93.46%84.11%-9.35%
    SetMutation.java94.44%97.22%+2.78%
    SQLiteOverlayMigrationManager.java82.50%90.48%+7.98%

Test Logs

Notes

  • Commit (9738d84) is created by Prow via merging PR base commit (8394f24) and head commit (621453c).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/H1hze4PfGW.html

@wu-hui wu-hui requested a review from ehsannas May 6, 2022 18:37
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (8394f24)Merge (9738d84)Diff
    aar1.26 MB1.26 MB+23 B (+0.0%)
    apk (release)3.38 MB3.38 MB-84 B (-0.0%)

Test Logs

Notes

  • Commit (9738d84) is created by Prow via merging PR base commit (8394f24) and head commit (621453c).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jVfQGrT1VP.html

@wu-hui wu-hui merged commit 7926a0a into master May 9, 2022
@wu-hui wu-hui deleted the wuandy/ActuallySkipOverlayMigration branch May 9, 2022 17:38
@firebase firebase locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@ehsannas ehsannas

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-hui @google-oss-bot @ehsannas