Skip to content

Attempt to fix flaky E2E screen trace by relaunching the activity. #3711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2022

Conversation

jeremyjiang-dev
Copy link
Contributor

The other test with _st_FirebasePerfScreenTracesActivity is not flaky and relaunches the activity at the end of the test, so I am trying to relaunch the activity to ensure the screen trace is sent.

@jeremyjiang-dev jeremyjiang-dev requested review from leotianlizhan and visumickey and removed request for leotianlizhan May 10, 2022 19:53
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (7926a0a) and merge commit (38d0cb3).

Test Logs

Notes

  • Commit (38d0cb3) is created by Prow via merging PR base commit (7926a0a) and head commit (4419abb).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4FJsTgiIDo.html

@jeremyjiang-dev
Copy link
Contributor Author

/run binary-size

@google-oss-bot
Copy link
Contributor

@jeremyjiang-dev: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 4419abb link /test smoke-tests
binary-size 4419abb link /run binary-size

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jeremyjiang-dev
Copy link
Contributor Author

Merging this PR.
binary-size and smoke-test checks are failed due to jcenter dependency, which is deprecated. These are not related to this PR.

@jeremyjiang-dev jeremyjiang-dev merged commit 4728a4e into master May 11, 2022
@jeremyjiang-dev jeremyjiang-dev deleted the perf-fix-e2e-flaky branch May 11, 2022 22:43
@firebase firebase locked and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants