Skip to content

Add app-check to BoM as they leave beta #3731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2022
Merged

Add app-check to BoM as they leave beta #3731

merged 1 commit into from
May 17, 2022

Conversation

davidmotson
Copy link
Collaborator

No description provided.

@davidmotson davidmotson requested a review from rlazo May 16, 2022 21:54
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.18% (0fbe11a) to 50.21% (0fa26b2) by +0.03%.

    FilenameBase (0fbe11a)Merge (0fa26b2)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
    ViewProcessor.java92.10%91.79%-0.30%

  • firebase-messaging

    Overall coverage changed from 84.83% (0fbe11a) to 84.91% (0fa26b2) by +0.08%.

    FilenameBase (0fbe11a)Merge (0fa26b2)Diff
    MessagingAnalytics.java81.38%82.19%+0.81%

  • firebase-perf

    Overall coverage changed from 71.41% (0fbe11a) to 71.43% (0fa26b2) by +0.02%.

    FilenameBase (0fbe11a)Merge (0fa26b2)Diff
    TransportManager.java95.35%95.81%+0.47%

Test Logs

Notes

  • Commit (0fa26b2) is created by Prow via merging PR base commit (0fbe11a) and head commit (8270664).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/93fyEMQDHv.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (0fbe11a) and merge commit (0fa26b2).

Test Logs

Notes

  • Commit (0fa26b2) is created by Prow via merging PR base commit (0fbe11a) and head commit (8270664).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/iLioG8moNZ.html

@davidmotson
Copy link
Collaborator Author

/retest

@rlazo rlazo merged commit 0f6d89b into master May 17, 2022
@rlazo rlazo deleted the davidmotson.bom_appcheck branch May 17, 2022 21:50
@firebase firebase locked and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidmotson @google-oss-bot @rlazo