Skip to content

Move transaction options to right release #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Move transaction options to right release #3789

merged 1 commit into from
Jun 8, 2022

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Jun 6, 2022

No description provided.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 46.16% (2bac92d) to 46.08% (18e9e73) by -0.08%.

    FilenameBase (2bac92d)Merge (18e9e73)Diff
    AsyncQueue.java77.61%77.11%-0.50%
    Datastore.java32.14%29.76%-2.38%
    FirestoreChannel.java18.10%16.38%-1.72%
    FirestoreClient.java38.24%33.09%-5.15%
    GrpcCallProvider.java55.29%51.76%-3.53%
    IndexBackfiller.java93.44%88.52%-4.92%
    LruGarbageCollector.java93.46%90.65%-2.80%
    SetMutation.java94.44%97.22%+2.78%

Test Logs

Notes

  • Commit (18e9e73) is created by Prow via merging PR base commit (2bac92d) and head commit (b3e7e57).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EjDdcyHJbv.html

Copy link
Contributor

@tom-andersen tom-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-hui wu-hui merged commit dafbef2 into master Jun 8, 2022
@wu-hui wu-hui deleted the wu-hui-patch-1 branch June 8, 2022 19:32
@firebase firebase locked and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants