Skip to content

Serving OR Queries from the client-side index. #3794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 14, 2022
Merged

Serving OR Queries from the client-side index. #3794

merged 4 commits into from
Jun 14, 2022

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Jun 7, 2022

No description provided.

@ehsannas ehsannas self-assigned this Jun 7, 2022
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 7, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (fb8544c)Merge (09ada07)Diff
    aar1.26 MB1.26 MB+7 B (+0.0%)
    apk (release)3.39 MB3.39 MB-172 B (-0.0%)

Test Logs

Notes

  • Commit (09ada07) is created by Prow via merging PR base commit (fb8544c) and head commit (1972ee1).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eFOdy73hTi.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 7, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 46.20% (fb8544c) to 46.20% (09ada07) by -0.00%.

    FilenameBase (fb8544c)Merge (09ada07)Diff
    AsyncQueue.java77.61%78.61%+1.00%
    GrpcCallProvider.java58.82%55.29%-3.53%
    PatchMutation.java100.00%98.39%-1.61%
    SQLiteIndexManager.java99.48%99.48%+0.00%

Test Logs

Notes

  • Commit (09ada07) is created by Prow via merging PR base commit (fb8544c) and head commit (1972ee1).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ph6VkiqV7L.html

@ehsannas ehsannas requested a review from wu-hui June 8, 2022 15:46
@ehsannas ehsannas assigned wu-hui and unassigned ehsannas Jun 8, 2022
@wu-hui wu-hui assigned ehsannas and unassigned wu-hui Jun 10, 2022
@ehsannas ehsannas assigned wu-hui and unassigned ehsannas Jun 13, 2022
@wu-hui wu-hui assigned ehsannas and unassigned wu-hui Jun 13, 2022
@ehsannas ehsannas assigned wu-hui and unassigned ehsannas Jun 13, 2022
wu-hui
wu-hui approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!!

@wu-hui wu-hui assigned ehsannas and unassigned wu-hui Jun 13, 2022
@ehsannas
Copy link
Contributor Author

/retest

@ehsannas ehsannas merged commit 943abd8 into master Jun 14, 2022
@ehsannas ehsannas deleted the ehsann/or-query-pr-10 branch June 14, 2022 15:31
@firebase firebase locked and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@ehsannas ehsannas

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @google-oss-bot @wu-hui