Ywmei/windows build #3801

ywmei-brt1 · 2022-06-11T05:44:45Z

adjust the file seperator so that this sdk code package can be build on windows machine
Ref: #2311 (comment)

Ref: #2311 (comment)

google-oss-bot · 2022-06-11T05:59:08Z

Coverage Report ¹

Affected Products

firebase-database
Overall coverage changed from 50.18% (8e28b5b) to 50.17% (a971c81) by -0.01%.
Filename Base (8e28b5b) Merge (a971c81) Diff
ViewProcessor.java 92.10% 91.79% -0.30%
firebase-firestore
Overall coverage changed from 46.21% (8e28b5b) to 46.19% (a971c81) by -0.02%.
Filename Base (8e28b5b) Merge (a971c81) Diff
AsyncQueue.java 78.61% 77.61% -1.00%
GrpcCallProvider.java 58.82% 55.29% -3.53%
SetMutation.java 97.22% 94.44% -2.78%
firebase-perf
Overall coverage changed from 71.40% (8e28b5b) to 71.43% (a971c81) by +0.03%.
Filename Base (8e28b5b) Merge (a971c81) Diff
TransportManager.java 94.88% 95.81% +0.93%
firebase-storage
Overall coverage changed from 85.85% (8e28b5b) to 86.24% (a971c81) by +0.39%.
Filename Base (8e28b5b) Merge (a971c81) Diff
StorageException.java 65.45% 69.09% +3.64%
StorageTask.java 84.29% 84.89% +0.60%
UploadTask.java 80.58% 82.37% +1.80%

Test Logs

Notes

Commit (a971c81) is created by Prow via merging PR base commit (8e28b5b) and head commit (59d0494).
Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

https://storage.googleapis.com/firebase-sdk-metric-reports/t4u6cDJHNl.html

google-oss-bot · 2022-06-11T06:03:55Z

Size Report ¹

Affected Products

No changes between base commit (8e28b5b) and merge commit (a971c81).

Test Logs

Notes

Commit (a971c81) is created by Prow via merging PR base commit (8e28b5b) and head commit (59d0494).

https://storage.googleapis.com/firebase-sdk-metric-reports/iBY9q9qffX.html

ywmei-brt1 · 2022-06-14T03:59:38Z

I have updated both the ThirdPartyLicensesExtension.java and the PublishingPlugin.java with setUrl(file.toURI()) method.

After these change, the entire project is able to sync on Windows machine, but when running firebase-inappmessaging-display:ktx's unit test, the following error message will be shown:

FAILURE: Build completed with 2 failures.
1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':transport:transport-runtime:generateReleaseProto'.
> protoc: stdout: . stderr: --firebaseEncoders_out: com.google.firebase.encoders.proto.codegen.InvalidConfigException: Config file 'E' does not exist or is a directory.
  
  	at com.google.firebase.encoders.proto.codegen.MainKt.driver(Main.kt:38)
  
  	at com.google.firebase.encoders.proto.codegen.MainKt.main(Main.kt:62)
  
  

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================
2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':transport:transport-runtime:generateDebugProto'.
> protoc: stdout: . stderr: --firebaseEncoders_out: com.google.firebase.encoders.proto.codegen.InvalidConfigException: Config file 'E' does not exist or is a directory.
  
  	at com.google.firebase.encoders.proto.codegen.MainKt.driver(Main.kt:38)
  
  	at com.google.firebase.encoders.proto.codegen.MainKt.main(Main.kt:62)

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================
Get more help at https://help.gradle.org`

rlazo

Thanks, it looks more consistent!

rlazo · 2022-06-14T04:05:46Z

Don't forget to update the test @ https://github.com/firebase/firebase-android-sdk/blob/ywmei/windows-build/buildSrc/src/test/kotlin/com/google/firebase/gradle/plugins/LicenseResolverPluginTests.kt

ywmei-brt1 · 2022-06-14T12:07:12Z

Don't forget to update the test @ https://github.com/firebase/firebase-android-sdk/blob/ywmei/windows-build/buildSrc/src/test/kotlin/com/google/firebase/gradle/plugins/LicenseResolverPluginTests.kt

I have updated the unit test, but when I try to run this unit test under firebase-andorid-sdk root, I got the following build fail message:

FAILURE: Build failed with an exception.
* What went wrong:
Project 'buildSrc' not found in root project 'com.google.firebase'.

Then, I tried to open the buildSrc as a independent Kotlin Project, I got the following sync fail message:

Execution failed for task ':wrapper'.
> Could not create task ':compileKotlin'.
   > org.gradle.api.internal.TaskInternal.setLoggerMessageRewriter(Lorg/gradle/internal/logging/slf4j/ContextAwareTaskLogger$MessageRewriter;)V

ywmei-brt1 · 2022-06-16T20:51:05Z

I have tried to run the unit test inside of the buildSrc directory, the build is success, but the test is skipped.
This thing is happen on both the master branch and this feature branch.

ywmei@ywmei:~/Workspace/SDK/firebase-android-sdk/buildSrc$ ../gradlew test --scan
Starting a Gradle Daemon, 3 busy Daemons could not be reused, use --status for details
> Task :compileKotlin UP-TO-DATE
> Task :compileJava UP-TO-DATE
> Task :pluginDescriptors UP-TO-DATE
> Task :processResources UP-TO-DATE
> Task :classes UP-TO-DATE
> Task :compileTestKotlin UP-TO-DATE
> Task :pluginUnderTestMetadata UP-TO-DATE
> Task :compileTestJava NO-SOURCE
> Task :processTestResources NO-SOURCE
> Task :testClasses UP-TO-DATE
> Task :test SKIPPED

BUILD SUCCESSFUL in 8s
6 actionable tasks: 6 up-to-date

rlazo · 2022-06-17T03:36:01Z

After looking into your issue reported (#3820 ) I reviewed our CI jobs. We have a build-plugins-check that runs in PRs that modify plugins. It passes, so you are good to go. If you want to run it locally, use

../gradlew -PenablePluginTests=true check

vkryachko · 2022-06-17T15:39:02Z

...rc/src/main/java/com/google/firebase/gradle/plugins/license/ThirdPartyLicensesExtension.java

      for (String s : licenseUris) {
-        this.licenseUris.add(URI.create(s));
+        File file = new File(s);


afaicr we used to allow specifying http(s) urls in thirdPartyLicenses{}, looks like it will no longer work.

I think it's fine since it has never been used, but wanted to call it out for future reference.

google-oss-bot added do-not-merge/work-in-progress size/M labels Jun 11, 2022

Support Windows Build to replace \ to /

f409aee

Ref: #2311 (comment)

ywmei-brt1 force-pushed the ywmei/windows-build branch from fd0dd33 to f409aee Compare June 11, 2022 05:58

google-oss-bot added size/S and removed size/M labels Jun 11, 2022

ywmei-brt1 assigned rlazo Jun 11, 2022

change licenseUris

da961dd

google-oss-bot added size/M and removed size/S labels Jun 14, 2022

rlazo reviewed Jun 14, 2022

View reviewed changes

update unit test

59d0494

ywmei-brt1 mentioned this pull request Jun 16, 2022

unit test for buildSrc does not run [both on Linux and Windows]. #3820

Closed

rlazo approved these changes Jun 17, 2022

View reviewed changes

rlazo requested a review from vkryachko June 17, 2022 03:36

rlazo removed the do-not-merge/work-in-progress label Jun 17, 2022

ywmei-brt1 marked this pull request as ready for review June 17, 2022 13:45

vkryachko approved these changes Jun 17, 2022

View reviewed changes

ywmei-brt1 merged commit ceb740d into master Jun 17, 2022

ywmei-brt1 deleted the ywmei/windows-build branch June 17, 2022 15:58

firebase locked and limited conversation to collaborators Jul 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Ywmei/windows build #3801

Ywmei/windows build #3801

Uh oh!

ywmei-brt1 commented Jun 11, 2022 •

edited

Loading

Uh oh!

google-oss-bot commented Jun 11, 2022 •

edited

Loading

`firebase-database`

`firebase-firestore`

`firebase-perf`

`firebase-storage`

Uh oh!

google-oss-bot commented Jun 11, 2022 •

edited

Loading

Uh oh!

ywmei-brt1 commented Jun 14, 2022

Uh oh!

rlazo left a comment

Uh oh!

rlazo commented Jun 14, 2022

Uh oh!

ywmei-brt1 commented Jun 14, 2022

Uh oh!

ywmei-brt1 commented Jun 16, 2022

Uh oh!

rlazo commented Jun 17, 2022

Uh oh!

vkryachko Jun 17, 2022

Uh oh!

Uh oh!

Ywmei/windows build #3801

Ywmei/windows build #3801

Uh oh!

Conversation

ywmei-brt1 commented Jun 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-oss-bot commented Jun 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

firebase-database

firebase-firestore

firebase-perf

firebase-storage

Test Logs

Notes

Uh oh!

google-oss-bot commented Jun 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

Test Logs

Notes

Uh oh!

ywmei-brt1 commented Jun 14, 2022

Uh oh!

rlazo left a comment

Choose a reason for hiding this comment

Uh oh!

rlazo commented Jun 14, 2022

Uh oh!

ywmei-brt1 commented Jun 14, 2022

Uh oh!

ywmei-brt1 commented Jun 16, 2022

Uh oh!

rlazo commented Jun 17, 2022

Uh oh!

vkryachko Jun 17, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ywmei-brt1 commented Jun 11, 2022 •

edited

Loading

google-oss-bot commented Jun 11, 2022 •

edited

Loading

Coverage Report ¹

`firebase-database`

`firebase-firestore`

`firebase-perf`

`firebase-storage`

google-oss-bot commented Jun 11, 2022 •

edited

Loading

Size Report ¹