Skip to content

Add upload request to TesterApiHttpClient #3810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 14, 2022
Merged

Add upload request to TesterApiHttpClient #3810

merged 4 commits into from
Jun 14, 2022

Conversation

lfkellogg
Copy link
Contributor

This will be used to upload screenshots. An upload request is just a POST to a different host with some extra headers.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 13, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (943abd8) to 79.74% (a6a0b0a) by ?.

    31 individual files with coverage change

    FilenameBase (943abd8)Merge (a6a0b0a)Diff
    AabUpdater.java?98.68%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?93.75%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?66.67%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?94.92%?
    FirebaseAppDistributionLifecycleNotifier.java?73.68%?
    FirebaseAppDistributionNotificationsManager.java?80.00%?
    FirebaseAppDistributionRegistrar.java?92.59%?
    FirebaseAppDistributionTesterApiClient.java?87.37%?
    HttpsUrlConnectionFactory.java?50.00%?
    InstallActivity.java?2.53%?
    LogWrapper.java?53.33%?
    NewReleaseFetcher.java?77.55%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?88.16%?
    ReleaseUtils.java?83.33%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?57.14%?
    TaskUtils.java?96.30%?
    TesterApiHttpClient.java?87.76%?
    TesterSignInManager.java?93.62%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskImpl.java?75.71%?

Test Logs

Notes

  • Commit (a6a0b0a) is created by Prow via merging PR base commit (943abd8) and head commit (8d4849d).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4Rp6McfYcl.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 13, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (943abd8)Merge (a6a0b0a)Diff
    aar127 kB128 kB+677 B (+0.5%)
    apk (aggressive)751 kB747 kB-4.10 kB (-0.5%)
    apk (release)1.59 MB1.59 MB+556 B (+0.0%)

Test Logs

Notes

  • Commit (a6a0b0a) is created by Prow via merging PR base commit (943abd8) and head commit (8d4849d).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/j5pwP4fZFZ.html

@lfkellogg lfkellogg force-pushed the lk/add-upload-screenshot branch from 24d79aa to 3d91fd9 Compare June 14, 2022 15:35
@lfkellogg lfkellogg merged commit da89e74 into master Jun 14, 2022
@lfkellogg lfkellogg deleted the lk/add-upload-screenshot branch June 14, 2022 20:01
@firebase firebase locked and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaibolay kaibolay kaibolay approved these changes

@rachaprince rachaprince Awaiting requested review from rachaprince

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lfkellogg @google-oss-bot @rachaprince @kaibolay