Skip to content

Update versions in gradle.properties #3843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2022
Merged

Update versions in gradle.properties #3843

merged 2 commits into from
Jul 4, 2022

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jun 23, 2022

No description provided.

@rlazo rlazo requested review from vkryachko and davidmotson June 23, 2022 21:00
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 23, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.96% (7d64cde) to 46.02% (9bcbcf4) by +0.06%.

    FilenameBase (7d64cde)Merge (9bcbcf4)Diff
    AsyncQueue.java77.61%78.61%+1.00%
    GrpcCallProvider.java55.29%69.41%+14.12%

  • firebase-messaging

    Overall coverage changed from ? (7d64cde) to 84.91% (9bcbcf4) by ?.

    41 individual files with coverage change

    FilenameBase (7d64cde)Merge (9bcbcf4)Diff
    AutoProtoEncoderDoNotUseEncoder.java?98.17%?
    ByteStreams.java?59.72%?
    CommonNotificationBuilder.java?90.38%?
    Constants.java?92.86%?
    DisplayNotification.java?91.38%?
    EnhancedIntentService.java?76.60%?
    ExecutorFactory.java?0.00%?
    FcmBroadcastProcessor.java?83.33%?
    FcmExecutors.java?80.00%?
    FcmLifecycleCallbacks.java?89.29%?
    FirebaseInstanceIdReceiver.java?72.73%?
    FirebaseMessaging.java?75.33%?
    FirebaseMessagingRegistrar.java?100.00%?
    FirebaseMessagingService.java?94.03%?
    GmsRpc.java?83.15%?
    ImageDownload.java?93.33%?
    MessagingAnalytics.java?82.19%?
    MessagingClientEvent.java?93.58%?
    MessagingClientEventExtension.java?76.47%?
    Metadata.java?57.14%?
    NotificationParams.java?98.71%?
    PoolableExecutors.java?29.17%?
    ProtoEncoderDoNotUse.java?50.00%?
    ProxyNotificationInitializer.java?93.75%?
    ProxyNotificationPreferences.java?88.89%?
    RemoteMessage.java?95.48%?
    RemoteMessageCreator.java?88.89%?
    RequestDeduplicator.java?90.00%?
    SendException.java?100.00%?
    ServiceStarter.java?87.50%?
    SharedPreferencesQueue.java?98.65%?
    Store.java?74.19%?
    SyncTask.java?70.83%?
    ThreadPriority.java?100.00%?
    TopicOperation.java?90.00%?
    TopicsStore.java?100.00%?
    TopicsSubscriber.java?89.47%?
    TopicsSyncTask.java?53.33%?
    WakeLockHolder.java?95.00%?
    WithinAppServiceBinder.java?90.91%?
    WithinAppServiceConnection.java?83.75%?

Test Logs

Notes

  • Commit (9bcbcf4) is created by Prow via merging PR base commit (7d64cde) and head commit (c4bdf1c).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/pcND5iJYKB.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 23, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-datatransport

    TypeBase (7d64cde)Merge (9bcbcf4)Diff
    aar5.14 kB5.13 kB-2 B (-0.0%)
    apk (aggressive)131 kB131 kB+4 B (+0.0%)

  • firebase-firestore

    TypeBase (7d64cde)Merge (9bcbcf4)Diff
    aar1.26 MB1.26 MB+1 B (+0.0%)
    apk (aggressive)489 kB489 kB+4 B (+0.0%)

  • firebase-messaging

    TypeBase (7d64cde)Merge (9bcbcf4)Diff
    aar142 kB142 kB+10 B (+0.0%)

  • firebase-messaging-directboot

    TypeBase (7d64cde)Merge (9bcbcf4)Diff
    aar10.1 kB10.1 kB-1 B (-0.0%)
    apk (release)1.11 MB1.11 MB+4 B (+0.0%)

Test Logs

Notes

  • Commit (9bcbcf4) is created by Prow via merging PR base commit (7d64cde) and head commit (c4bdf1c).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VViVOIlxTC.html

vkryachko
vkryachko approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@vkryachko vkryachko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding @yifanyang due to smoke tests failure

@vkryachko vkryachko requested a review from yifanyang June 24, 2022 15:05
@yifanyang
Copy link
Contributor

yifanyang commented Jun 24, 2022 •
edited
Loading

/test smoke-tests

Adding @yifanyang due to smoke tests failure

Not sure why but there was no log for the smoke tests failure. Let's rerun it and see. I think the failure should have nothing to do with this pull request.

yifanyang
yifanyang approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@yifanyang yifanyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test smoke-tests

Adding @yifanyang due to smoke tests failure

Not sure why but there was no log for the smoke tests failure. Let's rerun it and see. I think the failure should have nothing to do with this pull request.

The second run (link) failed with a flake from firestore tests, which should be irrelevant.

@rlazo
Copy link
Collaborator Author

rlazo commented Jun 30, 2022

/retest

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

Unit Test Results

   207 files   -    185     207 suites   - 185   7m 34s ⏱️ - 9m 23s
3 107 tests  - 1 592  3 090 ✔️  - 1 583  16 💤  - 6  1 ❌  - 3 
3 107 runs   - 1 608  3 090 ✔️  - 1 599  16 💤  - 6  1 ❌  - 3 

For more details on these failures, see this check.

Results for commit c4bdf1c. ± Comparison against base commit 7d64cde.

@rlazo
Copy link
Collaborator Author

rlazo commented Jul 4, 2022

/test check-changed

@rlazo rlazo merged commit feab85a into master Jul 4, 2022
@rlazo rlazo deleted the version_update_20220623 branch July 4, 2022 21:03
@firebase firebase locked and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

@yifanyang yifanyang yifanyang approved these changes

@davidmotson davidmotson Awaiting requested review from davidmotson

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rlazo @google-oss-bot @yifanyang @vkryachko