update kotlin from 1.3.72 to 1.4.32 #3855

thatfiredev · 2022-06-29T14:31:08Z

Since we can't yet upgrade to Kotlin 1.6 or later versions, I'm making small incremental changes to get us there.

google-oss-bot · 2022-06-29T14:37:05Z

Coverage Report ¹

Affected Products

firebase-database
Overall coverage changed from 50.23% (1737a87) to 50.16% (62e7c4a) by -0.07%.
Filename Base (1737a87) Merge (62e7c4a) Diff
ChildChangeAccumulator.java 96.67% 83.33% -13.33%
DoubleNode.java 100.00% 88.24% -11.76%
firebase-firestore
Overall coverage changed from 45.92% (1737a87) to 45.91% (62e7c4a) by -0.01%.
Filename Base (1737a87) Merge (62e7c4a) Diff
DeleteMutation.java 95.24% 90.48% -4.76%
PatchMutation.java 100.00% 98.39% -1.61%

`firebase-installations`

Overall coverage changed from ? (1737a87) to 60.10% (62e7c4a) by ?.

22 individual files with coverage change

Filename	Base (`1737a87`)	Merge (62e7c4a)	Diff
AutoValue_InstallationResponse.java	?	58.93%	?
AutoValue_PersistedInstallationEntry.java	?	61.18%	?
AutoValue_TokenResult.java	?	45.65%	?
AwaitListener.java	?	0.00%	?
Clock.java	?	0.00%	?
CrossProcessLock.java	?	51.85%	?
FirebaseInstallations.java	?	98.05%	?
FirebaseInstallationServiceClient.java	?	4.80%	?
FirebaseInstallationsException.java	?	78.57%	?
FirebaseInstallationsRegistrar.java	?	100.00%	?
GetAuthTokenListener.java	?	100.00%	?
GetIdListener.java	?	70.00%	?
IidStore.java	?	44.78%	?
InstallationResponse.java	?	100.00%	?
PersistedInstallation.java	?	97.01%	?
PersistedInstallationEntry.java	?	100.00%	?
RandomFidGenerator.java	?	20.00%	?
RequestLimiter.java	?	100.00%	?
StateListener.java	?	0.00%	?
SystemClock.java	?	100.00%	?
TokenResult.java	?	100.00%	?
Utils.java	?	95.00%	?

firebase-messaging
Overall coverage changed from 85.03% (1737a87) to 85.11% (62e7c4a) by +0.08%.
Filename Base (1737a87) Merge (62e7c4a) Diff
MessagingAnalytics.java 81.38% 82.19% +0.81%

Test Logs

Notes

Commit (62e7c4a) is created by Prow via merging PR base commit (1737a87) and head commit (0ad18c8).
Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

https://storage.googleapis.com/firebase-sdk-metric-reports/q5bx6kT7j7.html

thatfiredev · 2022-06-29T17:35:34Z

/retest

thatfiredev · 2022-06-29T17:36:44Z

/retest

google-oss-bot · 2022-06-29T20:14:25Z

Size Report ¹

Affected Products

firebase-appcheck-ktx
Type Base (1737a87) Merge (62e7c4a) Diff
aar 5.59 kB 5.60 kB +5 B (+0.1%)
apk (aggressive) 350 kB 349 kB -953 B (-0.3%)
apk (release) 1.47 MB 1.53 MB +63.6 kB (+4.3%)
firebase-appdistribution-api-ktx
Type Base (1737a87) Merge (62e7c4a) Diff
aar 6.13 kB 6.14 kB +5 B (+0.1%)
apk (aggressive) 101 kB 101 kB -937 B (-0.9%)
apk (release) 1.18 MB 1.24 MB +65.3 kB (+5.6%)
firebase-common-ktx
Type Base (1737a87) Merge (62e7c4a) Diff
aar 6.28 kB 6.34 kB +55 B (+0.9%)
apk (aggressive) 100 kB 99.3 kB -1.22 kB (-1.2%)
apk (release) 1.17 MB 1.22 MB +55.9 kB (+4.8%)
firebase-config-ktx
Type Base (1737a87) Merge (62e7c4a) Diff
aar 5.85 kB 5.86 kB +10 B (+0.2%)
apk (aggressive) 114 kB 113 kB -945 B (-0.8%)
apk (release) 1.22 MB 1.29 MB +66.7 kB (+5.5%)
firebase-crashlytics-ktx
Type Base (1737a87) Merge (62e7c4a) Diff
aar 6.85 kB 6.87 kB +13 B (+0.2%)
apk (aggressive) 232 kB 231 kB -921 B (-0.4%)
apk (release) 1.38 MB 1.44 MB +62.7 kB (+4.5%)
firebase-database-ktx
Type Base (1737a87) Merge (62e7c4a) Diff
aar 7.71 kB 7.67 kB -36 B (-0.5%)
apk (aggressive) 349 kB 348 kB -937 B (-0.3%)
apk (release) 1.63 MB 1.69 MB +64.3 kB (+4.0%)
firebase-dynamic-links-ktx
Type Base (1737a87) Merge (62e7c4a) Diff
aar 8.79 kB 8.80 kB +9 B (+0.1%)
apk (aggressive) 349 kB 348 kB -901 B (-0.3%)
apk (release) 1.47 MB 1.53 MB +65.0 kB (+4.4%)
firebase-firestore-ktx
Type Base (1737a87) Merge (62e7c4a) Diff
aar 7.47 kB 7.42 kB -45 B (-0.6%)
apk (aggressive) 505 kB 504 kB -941 B (-0.2%)
apk (release) 3.87 MB 3.94 MB +65.8 kB (+1.7%)
firebase-functions-ktx
Type Base (1737a87) Merge (62e7c4a) Diff
aar 6.14 kB 6.15 kB +9 B (+0.1%)
apk (aggressive) 413 kB 412 kB -961 B (-0.2%)
apk (release) 1.70 MB 1.76 MB +65.2 kB (+3.8%)
firebase-inappmessaging-display-ktx
Type Base (1737a87) Merge (62e7c4a) Diff
aar 22.2 kB 22.2 kB +11 B (+0.0%)
apk (aggressive) 1.51 MB 1.51 MB -937 B (-0.1%)
apk (release) 5.18 MB 5.24 MB +62.5 kB (+1.2%)
firebase-inappmessaging-ktx
Type Base (1737a87) Merge (62e7c4a) Diff
aar 5.29 kB 5.30 kB +7 B (+0.1%)
apk (aggressive) 680 kB 679 kB -929 B (-0.1%)
apk (release) 3.91 MB 3.97 MB +64.6 kB (+1.7%)
firebase-installations-ktx
Type Base (1737a87) Merge (62e7c4a) Diff
aar 5.28 kB 5.29 kB +3 B (+0.1%)
apk (aggressive) 102 kB 101 kB -917 B (-0.9%)
apk (release) 1.19 MB 1.26 MB +63.5 kB (+5.3%)
firebase-messaging-ktx
Type Base (1737a87) Merge (62e7c4a) Diff
aar 6.53 kB 6.55 kB +16 B (+0.2%)
apk (aggressive) 454 kB 453 kB -917 B (-0.2%)
apk (release) 1.63 MB 1.69 MB +66.6 kB (+4.1%)
firebase-ml-modeldownloader-ktx
Type Base (1737a87) Merge (62e7c4a) Diff
aar 6.40 kB 6.41 kB +14 B (+0.2%)
apk (aggressive) 159 kB 158 kB -901 B (-0.6%)
apk (release) 1.31 MB 1.37 MB +63.4 kB (+4.8%)
firebase-perf-ktx
Type Base (1737a87) Merge (62e7c4a) Diff
aar 19.5 kB 19.5 kB +28 B (+0.1%)
apk (aggressive) 1.04 MB 1.04 MB -961 B (-0.1%)
apk (release) 2.96 MB 3.02 MB +61.8 kB (+2.1%)
firebase-storage-ktx
Type Base (1737a87) Merge (62e7c4a) Diff
aar 7.29 kB 7.30 kB +8 B (+0.1%)
apk (aggressive) 348 kB 347 kB -933 B (-0.3%)
apk (release) 1.50 MB 1.56 MB +63.3 kB (+4.2%)

Test Logs

Notes

Commit (62e7c4a) is created by Prow via merging PR base commit (1737a87) and head commit (0ad18c8).

https://storage.googleapis.com/firebase-sdk-metric-reports/JTw0QaCpUC.html

thatfiredev · 2022-06-29T20:37:13Z

/test check-changed

rlazo

Kotlindoc still works after this change.

…-sdk into rpf-update-kotlin

thatfiredev · 2022-07-25T20:16:57Z

/test check-changed

* update kotlin from 1.3.72 to 1.4.32 * use compileOnly in tools/lint/lint.gradle * update dagger version in protoc-gen-firebase-encoders * stop using kotlin-stdlib-jdk7 in firebase-common * filter out only release component

update kotlin from 1.3.72 to 1.4.32

8adfdce

google-oss-bot added the size/XS label Jun 29, 2022

use compileOnly in tools/lint/lint.gradle

471353d

thatfiredev added 2 commits June 29, 2022 20:17

update dagger version in protoc-gen-firebase-encoders

a2bc8ad

stop using kotlin-stdlib-jdk7 in firebase-common

6f10870

google-oss-bot added size/S and removed size/XS labels Jun 29, 2022

filter out only release component

7a57193

rlazo self-requested a review July 25, 2022 17:30

rlazo approved these changes Jul 25, 2022

View reviewed changes

Merge branch 'master' of https://github.com/firebase/firebase-android…

0ad18c8

…-sdk into rpf-update-kotlin

rlazo merged commit 4bf252c into firebase:master Jul 26, 2022

martinbonnin mentioned this pull request Aug 4, 2022

Add 'toFlow()' extensions to DocumentSnapshot and Query #1252

Merged

firebase locked and limited conversation to collaborators Aug 26, 2022

update kotlin from 1.3.72 to 1.4.32 #3855

update kotlin from 1.3.72 to 1.4.32 #3855

Uh oh!

Conversation

thatfiredev commented Jun 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-oss-bot commented Jun 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

firebase-database

firebase-firestore

firebase-installations

firebase-messaging

Test Logs

Notes

Uh oh!

thatfiredev commented Jun 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thatfiredev commented Jun 29, 2022

Uh oh!

google-oss-bot commented Jun 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

firebase-appcheck-ktx

firebase-appdistribution-api-ktx

firebase-common-ktx

firebase-config-ktx

firebase-crashlytics-ktx

firebase-database-ktx

firebase-dynamic-links-ktx

firebase-firestore-ktx

firebase-functions-ktx

firebase-inappmessaging-display-ktx

firebase-inappmessaging-ktx

firebase-installations-ktx

firebase-messaging-ktx

firebase-ml-modeldownloader-ktx

firebase-perf-ktx

firebase-storage-ktx

Test Logs

Notes

Uh oh!

thatfiredev commented Jun 29, 2022

Uh oh!

rlazo left a comment

Choose a reason for hiding this comment

Uh oh!

thatfiredev commented Jul 25, 2022

Uh oh!

Uh oh!

thatfiredev commented Jun 29, 2022 •

edited

Loading

google-oss-bot commented Jun 29, 2022 •

edited

Loading

Coverage Report ¹

`firebase-database`

`firebase-firestore`

`firebase-installations`

`firebase-messaging`

thatfiredev commented Jun 29, 2022 •

edited

Loading

google-oss-bot commented Jun 29, 2022 •

edited

Loading

Size Report ¹

`firebase-appcheck-ktx`

`firebase-appdistribution-api-ktx`

`firebase-common-ktx`

`firebase-config-ktx`

`firebase-crashlytics-ktx`

`firebase-database-ktx`

`firebase-dynamic-links-ktx`

`firebase-firestore-ktx`

`firebase-functions-ktx`

`firebase-inappmessaging-display-ktx`

`firebase-inappmessaging-ktx`

`firebase-installations-ktx`

`firebase-messaging-ktx`

`firebase-ml-modeldownloader-ktx`

`firebase-perf-ktx`

`firebase-storage-ktx`