Skip to content

Support leaf modules in changed modules task. #3871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Conversation

vkryachko
Copy link
Member

The task should return the module even if nothing depends on it since it
likely has tests of its own.

The task should return the module even if nothing depends on it since it
likely has tests of its own.
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

buildSrc Test Results

18 tests   18 ✔️  2m 24s ⏱️
  4 suites    0 💤
  4 files      0

Results for commit 8e95b37.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

Unit Test Results

   392 files  ±0     392 suites  ±0   16m 50s ⏱️ +56s
4 699 tests ±0  4 677 ✔️ +2  22 💤 ±0  0  - 2 
4 715 runs  ±0  4 693 ✔️ +2  22 💤 ±0  0  - 2 

Results for commit 8e95b37. ± Comparison against base commit 921da2e.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.23% (921da2e) to 50.17% (fe3de78) by -0.05%.

    FilenameBase (921da2e)Merge (fe3de78)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
    ViewProcessor.java92.10%91.79%-0.30%
  • firebase-firestore

    Overall coverage changed from 45.83% (921da2e) to 45.86% (fe3de78) by +0.02%.

    FilenameBase (921da2e)Merge (fe3de78)Diff
    AsyncQueue.java77.11%78.11%+1.00%
    DeleteMutation.java90.48%95.24%+4.76%
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java94.44%97.22%+2.78%
  • firebase-messaging

    Overall coverage changed from 84.87% (921da2e) to 84.72% (fe3de78) by -0.15%.

    FilenameBase (921da2e)Merge (fe3de78)Diff
    TopicsSubscriber.java89.47%88.60%-0.88%
    TopicsSyncTask.java53.33%49.33%-4.00%
  • firebase-storage

    Overall coverage changed from 85.81% (921da2e) to 85.94% (fe3de78) by +0.13%.

    FilenameBase (921da2e)Merge (fe3de78)Diff
    UploadTask.java80.22%81.29%+1.08%

Test Logs

Notes

  • Commit (fe3de78) is created by Prow via merging PR base commit (921da2e) and head commit (fc5710d).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/q8hnzOPW4M.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 6, 2022

@vkryachko vkryachko requested a review from rlazo July 6, 2022 16:07
@vkryachko vkryachko merged commit 3c323f2 into master Jul 6, 2022
@vkryachko vkryachko deleted the vk.deps_fix branch July 6, 2022 16:27
@firebase firebase locked and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants