Skip to content

Firestore: Add @CanIgnoreReturnValue annotations in tests #3872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jul 6, 2022

Googlers see cl/457735855 from which this PR was ported.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

Unit Test Results

     78 files   -    314       78 suites   - 314   56s ⏱️ - 14m 58s
1 090 tests  - 3 609  1 074 ✔️  - 3 601  16 💤  - 6  0  - 2 
1 090 runs   - 3 625  1 074 ✔️  - 3 617  16 💤  - 6  0  - 2 

Results for commit c37de10. ± Comparison against base commit 921da2e.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (921da2e) and merge commit (a7ba569).

Test Logs

Notes

  • Commit (a7ba569) is created by Prow via merging PR base commit (921da2e) and head commit (c37de10).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UI9edKEWO8.html

@google-oss-bot
Copy link
Contributor

@dconeybe dconeybe merged commit f3f2f4c into master Jul 6, 2022
@dconeybe dconeybe deleted the dconeybe/CanIgnoreReturnValueAnnotationAdded branch July 6, 2022 16:49
@firebase firebase locked and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants