Skip to content

Remove usage of OPERATOR_UNSPECIFIED and use the real OR operator. #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2022
Merged

Remove usage of OPERATOR_UNSPECIFIED and use the real OR operator. #3888

merged 1 commit into from
Jul 18, 2022

Conversation

ehsannas
Copy link
Contributor

We had used OPERATOR_UNSPECIFIED in place of the OR enum because the proto was
not ready. Now that the proto has been updated, we can remove those.

Also found an out-of-date TODO and removed it.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2022 •
edited
Loading

Unit Test Results

1 090 tests  ±0   1 074 ✔️ ±0   56s ⏱️ +2s
     78 suites ±0        16 💤 ±0 
     78 files   ±0          0 ❌ ±0 

Results for commit f0de832. ± Comparison against base commit f5ac43c.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 11, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.92% (f5ac43c) to 45.79% (e38d599) by -0.13%.

    FilenameBase (f5ac43c)Merge (e38d599)Diff
    DeleteMutation.java95.24%90.48%-4.76%
    FirestoreClient.java33.09%30.88%-2.21%
    GrpcCallProvider.java62.35%48.24%-14.12%
    IndexBackfiller.java89.06%79.69%-9.38%
    LruGarbageCollector.java90.65%84.11%-6.54%
    PatchMutation.java100.00%98.39%-1.61%
    SetMutation.java97.22%94.44%-2.78%

Test Logs

Notes

  • Commit (e38d599) is created by Prow via merging PR base commit (f5ac43c) and head commit (f0de832).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Kz9hZGldHf.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 11, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (f5ac43c)Merge (e38d599)Diff
    aar1.26 MB1.26 MB-58 B (-0.0%)
    apk (release)3.39 MB3.39 MB-60 B (-0.0%)

Test Logs

Notes

  • Commit (e38d599) is created by Prow via merging PR base commit (f5ac43c) and head commit (f0de832).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/pRJvTNtGDb.html

@ehsannas ehsannas self-assigned this Jul 12, 2022
@ehsannas
Remove usage of OPERATOR_UNSPECIFIED and use the real OR operator.
f0de832 
We had used OPERATOR_UNSPECIFIED in place of the OR enum because the proto was
not ready. Now that the proto has been updated, we can remove those.

Also found an out-of-date TODO and removed it.
@ehsannas ehsannas force-pushed the ehsann/remove-operator-unspecified branch from ef82969 to f0de832 Compare July 13, 2022 15:49
@ehsannas ehsannas requested a review from wu-hui July 13, 2022 15:51
@ehsannas ehsannas assigned wu-hui and unassigned ehsannas Jul 13, 2022
@wu-hui wu-hui assigned ehsannas and unassigned wu-hui Jul 18, 2022
@ehsannas ehsannas merged commit 310ce36 into master Jul 18, 2022
@ehsannas ehsannas deleted the ehsann/remove-operator-unspecified branch July 18, 2022 18:00
@firebase firebase locked and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@ehsannas ehsannas

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @google-oss-bot @wu-hui