Skip to content

remove app indexing from the firebase-tutorial-bundle generator #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2022
Merged

remove app indexing from the firebase-tutorial-bundle generator #3906

merged 1 commit into from
Jul 25, 2022

Conversation

davidmotson
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

buildSrc Test Results

18 tests   18 ✔️  2m 31s ⏱️
  4 suites    0 💤
  4 files      0 ❌

Results for commit 2bf22e9.

@github-actions
Copy link
Contributor

Unit Test Results

   392 files  +   365     392 suites  +365   17m 4s ⏱️ + 16m 31s
4 701 tests +4 300  4 677 ✔️ +4 278  22 💤 +20  2 ❌ +2 
4 717 runs  +4 316  4 693 ✔️ +4 294  22 💤 +20  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 2bf22e9. ± Comparison against base commit 4cec8a4.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.17% (4cec8a4) to 50.18% (4c12472) by +0.01%.

    FilenameBase (4cec8a4)Merge (4c12472)Diff
    BooleanNode.java92.31%100.00%+7.69%

  • firebase-firestore

    Overall coverage changed from 45.91% (4cec8a4) to 45.91% (4c12472) by -0.00%.

    FilenameBase (4cec8a4)Merge (4c12472)Diff
    DeleteMutation.java95.24%90.48%-4.76%

  • firebase-messaging

    Overall coverage changed from 84.87% (4cec8a4) to 84.79% (4c12472) by -0.08%.

    FilenameBase (4cec8a4)Merge (4c12472)Diff
    MessagingAnalytics.java82.19%81.38%-0.81%

Test Logs

Notes

  • Commit (4c12472) is created by Prow via merging PR base commit (4cec8a4) and head commit (2bf22e9).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5WK9G299ug.html

@google-oss-bot
Copy link
Contributor

@davidmotson: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 2bf22e9 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (4cec8a4) and merge commit (4c12472).

Test Logs

Notes

  • Commit (4c12472) is created by Prow via merging PR base commit (4cec8a4) and head commit (2bf22e9).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uvt8FUVZF7.html

@davidmotson davidmotson merged commit c509030 into master Jul 25, 2022
@davidmotson davidmotson deleted the davidmotson.bom_appindexing branch July 25, 2022 19:53
lfkellogg pushed a commit that referenced this pull request Aug 5, 2022
@davidmotson @lfkellogg
remove app indexing from the firebase-tutorial-bundle generator (#3906)
863eacd 
Co-authored-by: David Motsonashvili <[email protected]>
@firebase firebase locked and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees

@rlazo rlazo

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidmotson @google-oss-bot @rlazo