Skip to content

Some cleanup in AabUpdaterTest #3921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Some cleanup in AabUpdaterTest #3921

merged 1 commit into from
Jul 19, 2022

Conversation

lfkellogg
Copy link
Contributor

Based on comments in #3920

@github-actions
Copy link
Contributor

Unit Test Results

139 tests  ±0   139 ✔️ ±0   38s ⏱️ +5s
  15 suites ±0       0 💤 ±0 
  15 files   ±0       0 ±0 

Results for commit 882a938. ± Comparison against base commit e2e41f5.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (e2e41f5) and merge commit (679c19d).

Test Logs

Notes

  • Commit (679c19d) is created by Prow via merging PR base commit (e2e41f5) and head commit (882a938).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mIZSv9kERv.html

Copy link
Contributor

@jladieu jladieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@google-oss-bot
Copy link
Contributor

@lfkellogg lfkellogg merged commit 8bd97a4 into master Jul 19, 2022
@lfkellogg lfkellogg deleted the lk/aab-test-cleanup branch July 19, 2022 21:26
@google-oss-bot
Copy link
Contributor

@lfkellogg: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 882a938 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@firebase firebase locked and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants