Skip to content

Remove binary. #3925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2022
Merged

Remove binary. #3925

merged 1 commit into from
Jul 20, 2022

Conversation

kaibolay
Copy link
Contributor

No description provided.

@kaibolay
Copy link
Contributor Author

I think this might have been added by accident.

@github-actions
Copy link
Contributor

Unit Test Results

144 tests   - 6   144 ✔️  - 6   43s ⏱️ -2s
  16 suites  - 1       0 💤 ±0 
  16 files    - 1       0 ❌ ±0 

Results for commit 90cad7f. ± Comparison against base commit ef964ec.

This pull request removes 6 tests. 
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ checkForNewRelease_failsWithNotImplemented
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ isTesterSignedIn_returnsFalse
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ signInTester_failsWithNotImplemented
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ signOutTester_doesNotThrow
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ updateApp
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ updateIfNewReleaseAvailable

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (ef964ec) and merge commit (76744e0).

Test Logs

Notes

  • Commit (76744e0) is created by Prow via merging PR base commit (ef964ec) and head commit (90cad7f).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WzfWKAZdZx.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (ef964ec) and merge commit (76744e0).

Test Logs

Notes

  • Commit (76744e0) is created by Prow via merging PR base commit (ef964ec) and head commit (90cad7f).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Ezucj3RDRh.html

@kaibolay kaibolay merged commit 5991287 into master Jul 20, 2022
@kaibolay kaibolay deleted the kb/no-test-binary branch July 20, 2022 16:55
@kaibolay kaibolay restored the kb/no-test-binary branch July 20, 2022 16:55
@firebase firebase locked and limited conversation to collaborators Aug 20, 2022
@kaibolay kaibolay deleted the kb/no-test-binary branch September 14, 2022 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfkellogg lfkellogg lfkellogg approved these changes

@rachaprince rachaprince Awaiting requested review from rachaprince

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaibolay @google-oss-bot @lfkellogg