Skip to content

Update messaging around API_DISABLED status #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2022
Merged

Update messaging around API_DISABLED status #3934

merged 1 commit into from
Jul 22, 2022

Conversation

lfkellogg
Copy link
Contributor

Based on feedback from vlukanovich@

@lfkellogg lfkellogg requested review from jladieu and kaibolay July 22, 2022 17:01
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (a51698e) and merge commit (570efba).

Test Logs

Notes

  • Commit (570efba) is created by Prow via merging PR base commit (a51698e) and head commit (a2108f9).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ii5DwVwxJn.html

@github-actions
Copy link
Contributor

Unit Test Results

150 tests   150 ✔️  49s ⏱️
  17 suites      0 💤
  17 files        0 ❌

Results for commit a2108f9.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (a51698e)Merge (570efba)Diff
    aar157 kB157 kB+2 B (+0.0%)
    apk (aggressive)880 kB880 kB+4 B (+0.0%)
    apk (release)2.01 MB2.01 MB+4 B (+0.0%)

Test Logs

Notes

  • Commit (570efba) is created by Prow via merging PR base commit (a51698e) and head commit (a2108f9).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KTrIT8sNSx.html

@lfkellogg lfkellogg merged commit 91b3148 into fad-in-app-feedback Jul 22, 2022
@lfkellogg lfkellogg deleted the lk/api-disabled-messaging branch July 22, 2022 17:23
@lfkellogg lfkellogg mentioned this pull request Jul 25, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaibolay kaibolay kaibolay approved these changes

@jladieu jladieu jladieu approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lfkellogg @google-oss-bot @jladieu @kaibolay