Skip to content

If modelHash is null pass emptyString to logger which requires non-nu… #3941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2022
Merged

If modelHash is null pass emptyString to logger which requires non-nu… #3941

merged 1 commit into from
Jul 27, 2022

Conversation

kabeer-uber
Copy link
Contributor

…ll modelHash

Fixes #3940

@google-oss-bot
Copy link
Contributor

Hi @kabeer-uber. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vkryachko
Copy link
Member

/ok-to-test

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-ml-modeldownloader

    Overall coverage changed from 83.94% (4bf252c) to 83.95% (b8bbe92) by +0.01%.

    FilenameBase (4bf252c)Merge (b8bbe92)Diff
    CustomModelDownloadService.java81.36%81.46%+0.10%

Test Logs

Notes

  • Commit (b8bbe92) is created by Prow via merging PR base commit (4bf252c) and head commit (ac5638c).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XbHFoxAp4n.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-ml-modeldownloader

    TypeBase (4bf252c)Merge (b8bbe92)Diff
    aar87.6 kB87.7 kB+43 B (+0.0%)
    apk (release)830 kB830 kB+120 B (+0.0%)

Test Logs

Notes

  • Commit (b8bbe92) is created by Prow via merging PR base commit (4bf252c) and head commit (ac5638c).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZQwP0Da1UH.html

@kabeer-uber
Copy link
Contributor Author

Thanks @vkryachko for the approval, looking forward to the merge and release in the next version.

@vkryachko
Copy link
Member

/retest

@vkryachko
Copy link
Member

also fyi @rlazo

@rlazo rlazo self-requested a review July 27, 2022 17:07
@rlazo rlazo merged commit ce4b1c0 into firebase:master Jul 27, 2022
lfkellogg pushed a commit that referenced this pull request Aug 5, 2022
@kabeer-uber @lfkellogg
If modelHash is null pass emptyString to logger which requires non-nu…
4962230 
…ll modelHash (#3941)
@firebase firebase locked and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Null pointer exception, due to null modelHash been passed to logger
4 participants
@kabeer-uber @google-oss-bot @vkryachko @rlazo