Add an extension point to ComponentRuntime. #3967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It allows augmenting/replacing components as they are requested from ComponentRegistrars. The motivation is to be able to measure initialization time of certain components and at the same time not to introduce this measurement logic directly to the components framework.
Size Report 1Affected Products
Test Logs
Notes |
Coverage Report 1Affected Products
Test Logs
Notes |
Unit Test Results 346 files - 45 346 suites - 45 14m 29s ⏱️ - 2m 15s For more details on these failures, see this check. Results for commit b1cdc39. ± Comparison against base commit 381bf87. ♻️ This comment has been updated with latest results. |
yifanyang
approved these changes
Aug 4, 2022
Comment on lines
+171
to
+176
| /** Creates a copy of the component with {@link ComponentFactory} replaced. */ | ||
| public Component<T> withFactory(ComponentFactory<T> factory) { | ||
| return new Component<>( | ||
| name, providedInterfaces, dependencies, instantiation, type, factory, publishedEvents); | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this for testing only? Looks like the purpose of ComponentFactory is only for product teams to implement. Once a product defined its factory in its registrars (and supply it via the component builder), it never needs to change?
There was a problem hiding this comment.
It's intended to be used outside of tests, for existing use example see:
emilypgoogle
approved these changes
Aug 4, 2022
lfkellogg
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Add an extension point to ComponentRuntime. It allows augmenting/replacing components as they are requested from ComponentRegistrars. The motivation is to be able to measure initialization time of certain components and at the same time not to introduce this measurement logic directly to the components framework. * add license.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows augmenting/replacing components as they are requested from
ComponentRegistrars.
The motivation is to be able to measure initialization time of
certain components and at the same time not to introduce this
measurement logic directly to the components framework.