Remove Firebase Predictions from the Firebase installation ID delete …

[jenh]

…comment as it was recently shut down; replace with Firebase A/B Testing, which also requires a FID.

[danasilver]

🚀

[google-oss-bot]

Size Report ¹

Affected Products

No changes between base commit (7261fd5) and merge commit (2255ea3).

Test Logs

• Base (7261fd5): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-binary-size/1557027910592761856
• Merge (2255ea3): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/3973/binary-size/1557033947236405250

Notes

• Commit (2255ea3) is created by Prow via merging PR base commit (7261fd5) and head commit (f85729c).

1. https://storage.googleapis.com/firebase-sdk-metric-reports/WY3yQhSBGp.html

[google-oss-bot]

Coverage Report ¹

Affected Products

No changes between base commit (7261fd5) and merge commit (2255ea3).

Test Logs

• Base (7261fd5): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-check-coverage/1557027910596956161
• Merge (2255ea3): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/3973/check-coverage-changed/1557033947236405249

Notes

• Commit (2255ea3) is created by Prow via merging PR base commit (7261fd5) and head commit (f85729c).
• Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

1. https://storage.googleapis.com/firebase-sdk-metric-reports/vas38if2Bf.html

[github-actions]

Unit Test Results

2 285 tests  +1 493   2 282 ✔️ +1 490   7m 54s ⏱️ + 3m 6s
   142 suites +     82          2 💤 +       2 
   142 files   +     82          1 ❌ +       1 

For more details on these failures, see this check.

Results for commit f85729c. ± Comparison against base commit af2a520.

♻️ This comment has been updated with latest results.

[jenh]

/retest

[thatfiredev]

We have a similar comment on the interface FirebaseInstallationsApi. Should we replace that too in this same PR?

firebase-android-sdk/firebase-installations-interop/src/main/java/com/google/firebase/installations/FirebaseInstallationsApi.java

Lines 51 to 56 in af2a520

	* Async function that deletes this Firebase app installation from Firebase backend. This call
	* would possibly lead Firebase Notification, Firebase RemoteConfig, Firebase Predictions or
	* Firebase In-App Messaging not function properly.
	*/
	@NonNull
	Task<Void> delete();

[jenh]

Great catch--thank you, Rosario! I've updated that file and added.

[thatfiredev]

The check-changed CI check is failing due to the formatting here. Autoformat suggested using this instead:

   * Async function that deletes this Firebase app installation from Firebase backend. This call may
   * cause Firebase Cloud Messaging, Firebase Remote Config, Firebase A/B Testing, or Firebase
   * In-App Messaging to not function properly.

Notice that the word "may" moved from the second line to the first and "Firebase" moved from the third line to the second.

[jenh]

Thanks a bunch, that did the trick!