-
Notifications
You must be signed in to change notification settings - Fork 624
Upgrade gRPC and remove OkHttp dependency #3975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report 1This report is too large (191,186 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test LogsNotes |
Size Report 1Affected Products
Test Logs
Notes |
With this change I suggest running |
Project ':firebase-firestore'_internal_aapt2_binary - The AAPT2 binary to use for processing resources. androidApis - Configuration providing various types of Android JAR file androidTestAnnotationProcessor - Classpath for the annotation processor for 'androidTest'. (n) androidTestApi - API dependencies for 'androidTest' sources. (n) androidTestCompile - Compile dependencies for 'androidTest' sources (deprecated: use 'androidTestImplementation' instead). (n) androidTestCompileOnly - Compile only dependencies for 'androidTest' sources. (n) androidTestDebugAnnotationProcessor - Classpath for the annotation processor for 'androidTestDebug'. (n) androidTestDebugApi - API dependencies for 'androidTestDebug' sources. (n) androidTestDebugCompile - Compile dependencies for 'androidTestDebug' sources (deprecated: use 'androidTestDebugImplementation' instead). (n) androidTestDebugCompileOnly - Compile only dependencies for 'androidTestDebug' sources. (n) androidTestDebugImplementation - Implementation only dependencies for 'androidTestDebug' sources. (n) androidTestDebugProtobuf androidTestDebugProvided - Provided dependencies for 'androidTestDebug' sources (deprecated: use 'androidTestDebugCompileOnly' instead). (n) androidTestDebugPublish - Publish dependencies for 'androidTestDebug' sources (deprecated: use 'androidTestDebugRuntimeOnly' instead). (n) androidTestDebugRuntimeOnly - Runtime only dependencies for 'androidTestDebug' sources. (n) androidTestDebugWearApp - Link to a wear app to embed for object 'androidTestDebug'. (n) androidTestImplementation - Implementation only dependencies for 'androidTest' sources. (n) androidTestProtobuf androidTestProvided - Provided dependencies for 'androidTest' sources (deprecated: use 'androidTestCompileOnly' instead). (n) androidTestPublish - Publish dependencies for 'androidTest' sources (deprecated: use 'androidTestRuntimeOnly' instead). (n) androidTestRuntimeOnly - Runtime only dependencies for 'androidTest' sources. (n) androidTestUtil - Additional APKs used during instrumentation testing. androidTestWearApp - Link to a wear app to embed for object 'androidTest'. (n) annotationProcessor - Classpath for the annotation processor for 'main'. (n) api - API dependencies for 'main' sources. (n) archives - Configuration for archive artifacts. (n) compile - Compile dependencies for 'main' sources (deprecated: use 'implementation' instead). compileOnly - Compile only dependencies for 'main' sources. (n) debugAndroidTestAnnotationProcessorClasspath - Resolved configuration for annotation-processor for variant: debugAndroidTest debugAndroidTestCompileClasspath - Resolved configuration for compilation for variant: debugAndroidTest debugAndroidTestRuntimeClasspath - Resolved configuration for runtime for variant: debugAndroidTest debugAnnotationProcessor - Classpath for the annotation processor for 'debug'. (n) debugAnnotationProcessorClasspath - Resolved configuration for annotation-processor for variant: debug debugApi - API dependencies for 'debug' sources. (n) debugApiElements - API elements for debug (n) debugCompile - Compile dependencies for 'debug' sources (deprecated: use 'debugImplementation' instead). (n) debugCompileClasspath - Resolved configuration for compilation for variant: debug debugCompileOnly - Compile only dependencies for 'debug' sources. (n) debugImplementation - Implementation only dependencies for 'debug' sources. (n) debugProtobuf debugProvided - Provided dependencies for 'debug' sources (deprecated: use 'debugCompileOnly' instead). (n) debugPublish - Publish dependencies for 'debug' sources (deprecated: use 'debugRuntimeOnly' instead). (n) debugRuntimeClasspath - Resolved configuration for runtime for variant: debug debugRuntimeElements - Runtime elements for debug (n) debugRuntimeOnly - Runtime only dependencies for 'debug' sources. (n) debugUnitTestAnnotationProcessorClasspath - Resolved configuration for annotation-processor for variant: debugUnitTest debugUnitTestCompileClasspath - Resolved configuration for compilation for variant: debugUnitTest debugUnitTestRuntimeClasspath - Resolved configuration for runtime for variant: debugUnitTest debugWearApp - Link to a wear app to embed for object 'debug'. (n) default - Configuration for default artifacts. (n) implementation - Implementation only dependencies for 'main' sources. (n) jacocoAgent - The Jacoco agent to use to get coverage data. jacocoAnt - The Jacoco ant tasks to use to get execute Gradle tasks. javadocClasspath ktlint - Main ktlint-gradle configuration ktlintReporter - All ktlint custom reporters dependencies ktlintRuleset - All ktlint rulesets dependencies lintChecks - Configuration to apply external lint check jar lintClassPath - The lint embedded classpath lintPublish - Configuration to publish external lint check jar protobuf protobufToolsLocator_grpc protobufToolsLocator_protoc provided - Provided dependencies for 'main' sources (deprecated: use 'compileOnly' instead). (n) publish - Publish dependencies for 'main' sources (deprecated: use 'runtimeOnly' instead). (n) releaseAnnotationProcessor - Classpath for the annotation processor for 'release'. (n) releaseAnnotationProcessorClasspath - Resolved configuration for annotation-processor for variant: release releaseApi - API dependencies for 'release' sources. (n) releaseApiElements - API elements for release (n) releaseCompile - Compile dependencies for 'release' sources (deprecated: use 'releaseImplementation' instead). (n) releaseCompileClasspath - Resolved configuration for compilation for variant: release releaseCompileOnly - Compile only dependencies for 'release' sources. (n) releaseImplementation - Implementation only dependencies for 'release' sources. (n) releaseProtobuf releaseProvided - Provided dependencies for 'release' sources (deprecated: use 'releaseCompileOnly' instead). (n) releasePublish - Publish dependencies for 'release' sources (deprecated: use 'releaseRuntimeOnly' instead). (n) releaseRuntimeClasspath - Resolved configuration for runtime for variant: release releaseRuntimeElements - Runtime elements for release (n) releaseRuntimeOnly - Runtime only dependencies for 'release' sources. (n) releaseUnitTestAnnotationProcessorClasspath - Resolved configuration for annotation-processor for variant: releaseUnitTest releaseUnitTestCompileClasspath - Resolved configuration for compilation for variant: releaseUnitTest releaseUnitTestRuntimeClasspath - Resolved configuration for runtime for variant: releaseUnitTest releaseWearApp - Link to a wear app to embed for object 'release'. (n) runtimeOnly - Runtime only dependencies for 'main' sources. (n) testAnnotationProcessor - Classpath for the annotation processor for 'test'. (n) testApi - API dependencies for 'test' sources. (n) testCompile - Compile dependencies for 'test' sources (deprecated: use 'testImplementation' instead). testCompileOnly - Compile only dependencies for 'test' sources. (n) testDebugAnnotationProcessor - Classpath for the annotation processor for 'testDebug'. (n) testDebugApi - API dependencies for 'testDebug' sources. (n) testDebugCompile - Compile dependencies for 'testDebug' sources (deprecated: use 'testDebugImplementation' instead). (n) testDebugCompileOnly - Compile only dependencies for 'testDebug' sources. (n) testDebugImplementation - Implementation only dependencies for 'testDebug' sources. (n) testDebugProtobuf testDebugProvided - Provided dependencies for 'testDebug' sources (deprecated: use 'testDebugCompileOnly' instead). (n) testDebugPublish - Publish dependencies for 'testDebug' sources (deprecated: use 'testDebugRuntimeOnly' instead). (n) testDebugRuntimeOnly - Runtime only dependencies for 'testDebug' sources. (n) testDebugWearApp - Link to a wear app to embed for object 'testDebug'. (n) testImplementation - Implementation only dependencies for 'test' sources. (n) testProtobuf testProvided - Provided dependencies for 'test' sources (deprecated: use 'testCompileOnly' instead). (n) testPublish - Publish dependencies for 'test' sources (deprecated: use 'testRuntimeOnly' instead). (n) testReleaseAnnotationProcessor - Classpath for the annotation processor for 'testRelease'. (n) testReleaseApi - API dependencies for 'testRelease' sources. (n) testReleaseCompile - Compile dependencies for 'testRelease' sources (deprecated: use 'testReleaseImplementation' instead). (n) testReleaseCompileOnly - Compile only dependencies for 'testRelease' sources. (n) testReleaseImplementation - Implementation only dependencies for 'testRelease' sources. (n) testReleaseProtobuf testReleaseProvided - Provided dependencies for 'testRelease' sources (deprecated: use 'testReleaseCompileOnly' instead). (n) testReleasePublish - Publish dependencies for 'testRelease' sources (deprecated: use 'testReleaseRuntimeOnly' instead). (n) testReleaseRuntimeOnly - Runtime only dependencies for 'testRelease' sources. (n) testReleaseWearApp - Link to a wear app to embed for object 'testRelease'. (n) testRuntimeOnly - Runtime only dependencies for 'test' sources. (n) testWearApp - Link to a wear app to embed for object 'test'. (n) wearApp - Link to a wear app to embed for object 'main'. (n) (c) - dependency constraint (n) - Not resolved (configuration is not meant to be resolved) |
I added output from dependencies command. The dependency on okhttp is gone. Please note that grpc-okhttp has no dependency on okhttp. The naming is historical. |
@tom-andersen: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.