Skip to content

Make @PreviewApi a documented annotation. #3976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Aug 9, 2022

We want methods annotated with @PreviewApi to include it in their javadoc.

We want methods annotated with @PreviewApi to include it in their javadoc.
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Unit Test Results

1 205 tests  +413   1 189 ✔️ +397   1m 11s ⏱️ - 3m 37s
     89 suites +  29        16 💤 +  16 
     89 files   +  29          0 ±    0 

Results for commit 8222a12. ± Comparison against base commit af2a520.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-annotations

    TypeBase (af2a520)Merge (f458ed2)Diff
    apk (release)8.88 kB8.89 kB+12 B (+0.1%)

Test Logs

Notes

  • Commit (f458ed2) is created by Prow via merging PR base commit (af2a520) and head commit (8222a12).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CgpyY4nqyE.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (af2a520) and merge commit (f458ed2).

Test Logs

Notes

  • Commit (f458ed2) is created by Prow via merging PR base commit (af2a520) and head commit (8222a12).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UYLKeYGBZy.html

@rlazo rlazo merged commit 7261fd5 into master Aug 9, 2022
@rlazo rlazo deleted the rl.documentedpreviewapi branch August 9, 2022 15:35
@firebase firebase locked and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants