Skip to content

Update project.path var to new location. #3985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2022
Merged

Update project.path var to new location. #3985

merged 2 commits into from
Aug 11, 2022

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Aug 11, 2022

No description provided.

@rlazo rlazo requested a review from vkryachko August 11, 2022 15:28
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 11, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-messaging

    Overall coverage changed from 85.11% (c6cc8c5) to 85.03% (5180004) by -0.08%.

    FilenameBase (c6cc8c5)Merge (5180004)Diff
    FirebaseMessaging.java74.89%74.45%-0.44%
    Metadata.java57.14%61.90%+4.76%
    TopicsSubscriber.java89.47%88.60%-0.88%
    TopicsSyncTask.java53.33%49.33%-4.00%

  • firebase-storage

    Overall coverage changed from 85.85% (c6cc8c5) to 86.03% (5180004) by +0.17%.

    FilenameBase (c6cc8c5)Merge (5180004)Diff
    UploadTask.java80.58%82.01%+1.44%

  • firebase-firestore

    FilenameBase (c6cc8c5)Merge (5180004)Diff
    DeleteMutation.java95.24%90.48%-4.76%
    PatchMutation.java98.39%100.00%+1.61%

Test Logs

Notes

  • Commit (5180004) is created by Prow via merging PR base commit (c6cc8c5) and head commit (eca8819).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HZVvOmTVka.html

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2022 •
edited
Loading

Unit Test Results

   391 files  +   249     391 suites  +249   16m 10s ⏱️ + 8m 11s
4 701 tests +2 416  4 676 ✔️ +2 394  22 💤 +20  3 ❌ +2 
4 717 runs  +2 432  4 692 ✔️ +2 410  22 💤 +20  3 ❌ +2 

For more details on these failures, see this check.

Results for commit eca8819. ± Comparison against base commit c6cc8c5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

buildSrc Test Results

18 tests   18 ✔️  2m 17s ⏱️
  4 suites    0 💤
  4 files      0 ❌

Results for commit eca8819.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (c6cc8c5) and merge commit (5180004).

Test Logs

Notes

  • Commit (5180004) is created by Prow via merging PR base commit (c6cc8c5) and head commit (eca8819).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uZtBYBKLU3.html

@rlazo rlazo merged commit 089c828 into master Aug 11, 2022
@rlazo rlazo deleted the rl.projectpathchange branch August 11, 2022 18:32
vkryachko added a commit that referenced this pull request Sep 9, 2022
@vkryachko
Revert "Update project.path var to new location. (#3985)"
2227522 
This reverts commit 089c828.
@vkryachko vkryachko mentioned this pull request Sep 9, 2022
Merged
vkryachko added a commit that referenced this pull request Sep 9, 2022
@vkryachko
Revert "Update project.path var to new location. (#3985)" (#4073)
3280a27 
This reverts commit 089c828.
@firebase firebase locked and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @vkryachko