-
Notifications
You must be signed in to change notification settings - Fork 625
fix synchrnoized wrong object while manipulating appColdStartSubscribers #3992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix synchrnoized wrong object while manipulating appColdStartSubscribers #3992
Conversation
Hi @Knight-ZXW. Thanks for your PR. I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching and fixing this!
@jeremyjiang-dev could you merge this MR? |
/test api-information-check |
/retest |
@yifanyang Could you take a look why the api check is still in progress? |
We recently migrated presubmit jobs to GitHub Actions. I suppose this pull request was created during the short period where the the api job was removed from Prow, but GitHub is still expecting it. Anyway, I have merged it manually. |
Thank you, Yifan! |
No description provided.