Skip to content

fix synchrnoized wrong object while manipulating appColdStartSubscribers #3992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

Knight-ZXW
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

Hi @Knight-ZXW. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeremyjiang-dev
Copy link
Contributor

/ok-to-test

@Knight-ZXW Knight-ZXW requested review from 88rogikl88 and removed request for visumickey and jeremyjiang-dev August 19, 2022 09:50
@vkryachko vkryachko requested review from jeremyjiang-dev and removed request for 88rogikl88 August 19, 2022 15:01
Copy link
Contributor

@jeremyjiang-dev jeremyjiang-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this!

@Knight-ZXW
Copy link
Contributor Author

@jeremyjiang-dev could you merge this MR?

@jeremyjiang-dev
Copy link
Contributor

/test api-information-check

@jeremyjiang-dev
Copy link
Contributor

/retest

@jeremyjiang-dev
Copy link
Contributor

@yifanyang Could you take a look why the api check is still in progress?

@yifanyang yifanyang merged commit 3f13291 into firebase:master Aug 29, 2022
@yifanyang
Copy link
Contributor

@jeremyjiang-dev

@yifanyang Could you take a look why the api check is still in progress?

We recently migrated presubmit jobs to GitHub Actions. I suppose this pull request was created during the short period where the the api job was removed from Prow, but GitHub is still expecting it. Anyway, I have merged it manually.

@jeremyjiang-dev
Copy link
Contributor

@jeremyjiang-dev

@yifanyang Could you take a look why the api check is still in progress?

We recently migrated presubmit jobs to GitHub Actions. I suppose this pull request was created during the short period where the the api job was removed from Prow, but GitHub is still expecting it. Anyway, I have merged it manually.

Thank you, Yifan!

@firebase firebase locked and limited conversation to collaborators Sep 29, 2022
@Knight-ZXW Knight-ZXW deleted the fix_synchronize_wrong_object branch February 28, 2023 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants