Create Gradle cache-compliant metalava tasks. #3994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original tasks were not properly cacheable and will fail validation in future Gradle versions.
Unit Test Results 391 files ±0 391 suites ±0 16m 1s ⏱️ - 1m 5s For more details on these failures, see this check. Results for commit b40193c. ± Comparison against base commit ba6f410. ♻️ This comment has been updated with latest results. |
Size Report 1Affected ProductsTest Logs
Notes |
Coverage Report 1Affected Products
Test Logs
Notes |
rlazo
reviewed
Aug 16, 2022
| this.dependencies.add([email protected]("com.android:metalava:1.3.0")) | ||
| } | ||
| ?: configurations.create("metalavaArtifacts") { | ||
| this.dependencies.add([email protected]("com.android.tools.metalava:metalava:1.0.0-alpha06")) |
There was a problem hiding this comment.
question: is this a newer or older version?
There was a problem hiding this comment.
this is a newer version
| "--hide", | ||
| "HiddenSuperclass", // We allow having a hidden parent class | ||
| "--hide", | ||
| "HiddenAbstractMethod" |
There was a problem hiding this comment.
This is a new check metalava added, similar to the one you fixed in piper for auth
| method @NonNull public static com.google.firebase.database.FirebaseDatabase database(@NonNull com.google.firebase.ktx.Firebase, @NonNull String url); | ||
| method @NonNull public static com.google.firebase.database.FirebaseDatabase database(@NonNull com.google.firebase.ktx.Firebase, @NonNull com.google.firebase.FirebaseApp app); | ||
| method @NonNull public static com.google.firebase.database.FirebaseDatabase database(@NonNull com.google.firebase.ktx.Firebase, @NonNull com.google.firebase.FirebaseApp app, @NonNull String url); | ||
| method @NonNull public static com.google.firebase.database.FirebaseDatabase getDatabase(@NonNull com.google.firebase.ktx.Firebase); | ||
| method @Nullable public static inline <reified T> T getValue(@NonNull com.google.firebase.database.DataSnapshot); | ||
| method @Nullable public static inline <reified T> T getValue(@NonNull com.google.firebase.database.MutableData); | ||
| method public static inline <reified T> T getValue(@NonNull com.google.firebase.database.DataSnapshot); |
There was a problem hiding this comment.
This has changed from nullable to not annotated. Would this be an issue?
Here and below
There was a problem hiding this comment.
I've been wondering that same thing, filed a bug internally http://b/242720906
|
/retest |
rlazo
approved these changes
Aug 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original tasks were not properly cacheable and will fail validation
in future Gradle versions.