Skip to content

Use more explanatory name for API information job #3997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Conversation

yifanyang
Copy link
Contributor

@yifanyang yifanyang commented Aug 16, 2022

When configuring required status checks to pass in branch protection rules, the status checks are distinguished only by the job names, regardless of their workflow name. Therefore, individual job names need to be more self-explanatory.

@google-oss-bot
Copy link
Contributor

@yifanyang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-coverage-changed 6405ec6 link /test check-coverage-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (d82eaa0) and merge commit (0d4013e).

Test Logs

Notes

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uDFvnQSYjz.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (d82eaa0) to 79.31% (0d4013e) by ?.

    34 individual files with coverage change

    FilenameBase (d82eaa0)Merge (0d4013e)Diff
    AabUpdater.java?98.68%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?93.75%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?66.67%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?94.90%?
    FirebaseAppDistributionLifecycleNotifier.java?75.00%?
    FirebaseAppDistributionNotificationsManager.java?80.00%?
    FirebaseAppDistributionRegistrar.java?92.59%?
    FirebaseAppDistributionTesterApiClient.java?87.63%?
    HttpsUrlConnectionFactory.java?50.00%?
    InstallActivity.java?2.53%?
    LogWrapper.java?53.33%?
    NewReleaseFetcher.java?77.55%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?88.00%?
    ReleaseUtils.java?83.33%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?57.14%?
    TaskUtils.java?96.30%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?89.19%?
    TesterSignInManager.java?93.62%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskImpl.java?75.71%?

  • firebase-database

    Overall coverage changed from 50.18% (d82eaa0) to 50.16% (0d4013e) by -0.02%.

    FilenameBase (d82eaa0)Merge (0d4013e)Diff
    DoubleNode.java100.00%88.24%-11.76%
  • firebase-firestore

    Overall coverage changed from 46.01% (d82eaa0) to 46.03% (0d4013e) by +0.01%.

    FilenameBase (d82eaa0)Merge (0d4013e)Diff
    DeleteMutation.java90.48%95.24%+4.76%
    SetMutation.java94.44%97.22%+2.78%
    SQLitePersistence.java86.34%86.89%+0.55%

Test Logs

Notes

  • Commit (0d4013e) is created by Prow via merging PR base commit (d82eaa0) and head commit (6405ec6).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/42YRFhqK38.html

@github-actions
Copy link
Contributor

Unit Test Results

   391 files  ±0     391 suites  ±0   16m 28s ⏱️ +19s
4 707 tests ±0  4 685 ✔️ +1  22 💤 ±0  0  - 1 
4 723 runs  ±0  4 701 ✔️ +1  22 💤 ±0  0  - 1 

Results for commit 6405ec6. ± Comparison against base commit d82eaa0.

@yifanyang yifanyang requested a review from vkryachko August 16, 2022 19:23
@yifanyang yifanyang merged commit 9d927a5 into master Aug 16, 2022
@yifanyang yifanyang deleted the yifany/api-info branch August 16, 2022 21:13
@firebase firebase locked and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants