Use the more common stdlib dep now that we ship java8 bytecode. #4002

vkryachko · 2022-08-17T14:35:55Z

Additionally fix pom dependency type resolution.

github-actions · 2022-08-17T14:40:14Z

buildSrc Test Results

18 tests 18 ✔️ 2m 10s ⏱️
  4 suites   0 💤
  4 files   0 ❌

Results for commit 951df8a.

github-actions · 2022-08-17T14:49:18Z

Unit Test Results

  391 files +  55   391 suites +55 16m 7s ⏱️ + 1m 40s
4 707 tests +425 4 685 ✔️ +429 22 💤 ±0 0 ❌ - 4
4 723 runs +425 4 701 ✔️ +429 22 💤 ±0 0 ❌ - 4

Results for commit 951df8a. ± Comparison against base commit 75ea92c.

thatfiredev · 2022-08-17T14:53:53Z

Starting in Kotlin 1.4, the stdlib dependency is added by default. I wonder if we have tried removing the dependency from our gradle files?

vkryachko · 2022-08-17T14:56:07Z

Starting in Kotlin 1.4, the stdlib dependency is added by default. I wonder if we have tried removing the dependency from our gradle files?

Yeah I tried that, but it does not work, likely because we have this in our code

firebase-android-sdk/firebase-common/firebase-common.gradle

Line 78 in 75ea92c

compileOnly "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlinVersion"

I think it confuses the plugin and the dep is not added

vkryachko · 2022-08-17T15:02:04Z

/retest

vkryachko · 2022-08-17T15:03:06Z

@thatfiredev unrelated to this change, looks like appcheck:ktx has a failing test due to a missing KtxRegistrar, can you please take a look?

google-oss-bot · 2022-08-17T15:08:23Z

Size Report ¹

Affected Products

firebase-appcheck-ktx
Type Base (75ea92c) Merge (6cec01a) Diff
apk (aggressive) 351 kB 346 kB -4.36 kB (-1.2%)
apk (release) 1.53 MB 1.52 MB -10.7 kB (-0.7%)
firebase-appdistribution-api-ktx
Type Base (75ea92c) Merge (6cec01a) Diff
apk (aggressive) 101 kB 100 kB -267 B (-0.3%)
apk (release) 1.24 MB 1.23 MB -9.31 kB (-0.7%)
firebase-config-ktx
Type Base (75ea92c) Merge (6cec01a) Diff
apk (aggressive) 113 kB 113 kB -267 B (-0.2%)
apk (release) 1.29 MB 1.28 MB -10.9 kB (-0.8%)
firebase-crashlytics-ktx
Type Base (75ea92c) Merge (6cec01a) Diff
apk (aggressive) 231 kB 231 kB -267 B (-0.1%)
apk (release) 1.44 MB 1.43 MB -10.0 kB (-0.7%)
firebase-database-ktx
Type Base (75ea92c) Merge (6cec01a) Diff
apk (aggressive) 349 kB 349 kB -267 B (-0.1%)
apk (release) 1.69 MB 1.68 MB -10.6 kB (-0.6%)
firebase-dynamic-links-ktx
Type Base (75ea92c) Merge (6cec01a) Diff
apk (aggressive) 350 kB 349 kB -267 B (-0.1%)
apk (release) 1.53 MB 1.52 MB -10.4 kB (-0.7%)
firebase-functions-ktx
Type Base (75ea92c) Merge (6cec01a) Diff
apk (aggressive) 413 kB 413 kB -267 B (-0.1%)
apk (release) 1.76 MB 1.75 MB -9.90 kB (-0.6%)
firebase-inappmessaging-display-ktx
Type Base (75ea92c) Merge (6cec01a) Diff
apk (aggressive) 1.51 MB 1.51 MB -267 B (-0.0%)
apk (release) 5.24 MB 5.23 MB -10.5 kB (-0.2%)
firebase-inappmessaging-ktx
Type Base (75ea92c) Merge (6cec01a) Diff
apk (aggressive) 680 kB 679 kB -267 B (-0.0%)
apk (release) 3.97 MB 3.96 MB -8.87 kB (-0.2%)
firebase-installations-ktx
Type Base (75ea92c) Merge (6cec01a) Diff
apk (aggressive) 102 kB 101 kB -271 B (-0.3%)
apk (release) 1.26 MB 1.25 MB -9.00 kB (-0.7%)
firebase-messaging-ktx
Type Base (75ea92c) Merge (6cec01a) Diff
apk (aggressive) 454 kB 454 kB -267 B (-0.1%)
apk (release) 1.69 MB 1.68 MB -10.1 kB (-0.6%)
firebase-ml-modeldownloader-ktx
Type Base (75ea92c) Merge (6cec01a) Diff
apk (aggressive) 158 kB 158 kB -267 B (-0.2%)
apk (release) 1.38 MB 1.37 MB -8.07 kB (-0.6%)
firebase-perf-ktx
Type Base (75ea92c) Merge (6cec01a) Diff
apk (aggressive) 1.04 MB 1.04 MB -267 B (-0.0%)
apk (release) 3.02 MB 3.01 MB -8.05 kB (-0.3%)
firebase-storage-ktx
Type Base (75ea92c) Merge (6cec01a) Diff
apk (aggressive) 349 kB 348 kB -271 B (-0.1%)
apk (release) 1.56 MB 1.55 MB -8.78 kB (-0.6%)

Test Logs

Notes

Commit (6cec01a) is created by Prow via merging PR base commit (75ea92c) and head commit (951df8a).

https://storage.googleapis.com/firebase-sdk-metric-reports/yWPEVpewXC.html

thatfiredev · 2022-08-17T15:08:58Z

@vkryachko I was hoping that'd be fixed in #3974, but I can open a separate PR to add the Registrar before that one gets merged.

google-oss-bot · 2022-08-17T15:15:55Z

Coverage Report ¹

Affected Products

`firebase-common`

Overall coverage changed from ? (75ea92c) to 65.16% (6cec01a) by ?.

30 individual files with coverage change

Filename	Base (`75ea92c`)	Merge (`6cec01a`)	Diff
AutoValue_HeartBeatResult.java	?	33.33%	?
AutoValue_LibraryVersion.java	?	58.33%	?
AutoValue_SdkHeartBeatResult.java	?	0.00%	?
ComponentDiscoveryService.java	?	0.00%	?
DataCollectionConfigStorage.java	?	88.89%	?
DataCollectionDefaultChange.java	?	100.00%	?
DefaultHeartBeatController.java	?	94.03%	?
DefaultUserAgentPublisher.java	?	95.45%	?
EmulatedServiceSettings.java	?	0.00%	?
FirebaseApp.java	?	54.25%	?
FirebaseAppLifecycleListener.java	?	0.00%	?
FirebaseCommonRegistrar.java	?	95.74%	?
FirebaseError.java	?	0.00%	?
FirebaseInitProvider.java	?	58.82%	?
FirebaseNetworkException.java	?	0.00%	?
FirebaseOptions.java	?	31.94%	?
FirebaseTooManyRequestsException.java	?	0.00%	?
GlobalLibraryVersionRegistrar.java	?	75.00%	?
HeartBeatConsumer.java	?	0.00%	?
HeartBeatConsumerComponent.java	?	0.00%	?
HeartBeatController.java	?	0.00%	?
HeartBeatInfo.java	?	100.00%	?
HeartBeatInfoStorage.java	?	90.57%	?
HeartBeatResult.java	?	100.00%	?
KotlinDetector.java	?	66.67%	?
LibraryVersion.java	?	100.00%	?
LibraryVersionComponent.java	?	100.00%	?
PublicApi.java	?	0.00%	?
SdkHeartBeatResult.java	?	0.00%	?
UserAgentPublisher.java	?	0.00%	?

firebase-database
Overall coverage changed from 50.17% (75ea92c) to 50.15% (6cec01a) by -0.02%.
Filename Base (75ea92c) Merge (6cec01a) Diff
ChildChangeAccumulator.java 96.67% 83.33% -13.33%
DefaultPersistenceManager.java 74.76% 75.73% +0.97%
QueryParams.java 89.76% 90.36% +0.60%

`firebase-firestore`

Overall coverage changed from 45.98% (75ea92c) to 45.92% (6cec01a) by -0.07%.

Filename	Base (`75ea92c`)	Merge (`6cec01a`)	Diff
AsyncQueue.java	78.61%	78.11%	-0.50%
FirestoreClient.java	38.24%	33.09%	-5.15%
IndexBackfiller.java	93.75%	89.06%	-4.69%
LruGarbageCollector.java	93.46%	90.65%	-2.80%
PatchMutation.java	100.00%	98.39%	-1.61%
SetMutation.java	97.22%	94.44%	-2.78%

`firebase-perf`

Overall coverage changed from ? (75ea92c) to 71.40% (6cec01a) by ?.

101 individual files with coverage change

Filename	Base (`75ea92c`)	Merge (`6cec01a`)	Diff
AddTrace.java	?	0.00%	?
AndroidApplicationInfo.java	?	34.71%	?
AndroidApplicationInfoOrBuilder.java	?	0.00%	?
AndroidLogger.java	?	100.00%	?
AndroidMemoryReading.java	?	38.36%	?
AndroidMemoryReadingOrBuilder.java	?	0.00%	?
ApplicationInfo.java	?	45.00%	?
ApplicationInfoOrBuilder.java	?	0.00%	?
ApplicationProcessState.java	?	73.91%	?
AppStartTrace.java	?	86.54%	?
AppStateMonitor.java	?	86.71%	?
AppStateUpdateHandler.java	?	92.86%	?
Clock.java	?	100.00%	?
ConfigResolver.java	?	97.38%	?
ConfigurationConstants.java	?	99.25%	?
ConfigurationFlag.java	?	100.00%	?
ConsoleUrlGenerator.java	?	37.50%	?
Constants.java	?	95.65%	?
Counter.java	?	90.91%	?
CpuGaugeCollector.java	?	92.77%	?
CpuMetricReading.java	?	39.33%	?
CpuMetricReadingOrBuilder.java	?	0.00%	?
DaggerFirebasePerformanceComponent.java	?	100.00%	?
DeviceCacheManager.java	?	76.03%	?
FirebasePerfApplicationInfoValidator.java	?	92.86%	?
FirebasePerfGaugeMetricValidator.java	?	100.00%	?
FirebasePerfHttpClient.java	?	93.85%	?
FirebasePerfMetricProto.java	?	0.00%	?
FirebasePerfNetworkValidator.java	?	86.67%	?
FirebasePerfOkHttpClient.java	?	44.90%	?
FirebasePerformance.java	?	79.12%	?
FirebasePerformanceAttributable.java	?	0.00%	?
FirebasePerformanceComponent.java	?	0.00%	?
FirebasePerformanceInitializer.java	?	33.33%	?
FirebasePerformanceModule.java	?	100.00%	?
FirebasePerformanceModule_ProvidesConfigResolverFactory.java	?	100.00%	?
FirebasePerformanceModule_ProvidesFirebaseAppFactory.java	?	100.00%	?
FirebasePerformanceModule_ProvidesFirebaseInstallationsFactory.java	?	100.00%	?
FirebasePerformanceModule_ProvidesRemoteConfigComponentFactory.java	?	100.00%	?
FirebasePerformanceModule_ProvidesRemoteConfigManagerFactory.java	?	100.00%	?
FirebasePerformanceModule_ProvidesSessionManagerFactory.java	?	100.00%	?
FirebasePerformanceModule_ProvidesTransportFactoryProviderFactory.java	?	100.00%	?
FirebasePerformance_Factory.java	?	100.00%	?
FirebasePerfProvider.java	?	76.92%	?
FirebasePerfRegistrar.java	?	100.00%	?
FirebasePerfTraceValidator.java	?	85.87%	?
FirebasePerfUrlConnection.java	?	44.26%	?
FlgTransport.java	?	83.33%	?
FragmentStateMonitor.java	?	94.87%	?
FrameMetricsCalculator.java	?	96.77%	?
FrameMetricsRecorder.java	?	78.38%	?
GaugeManager.java	?	98.43%	?
GaugeMetadata.java	?	32.21%	?
GaugeMetadataManager.java	?	84.21%	?
GaugeMetadataOrBuilder.java	?	0.00%	?
GaugeMetric.java	?	39.47%	?
GaugeMetricOrBuilder.java	?	0.00%	?
HttpMetric.java	?	92.65%	?
ImmutableBundle.java	?	100.00%	?
InstrHttpInputStream.java	?	92.86%	?
InstrHttpOutputStream.java	?	98.00%	?
InstrHttpsURLConnection.java	?	94.32%	?
InstrHttpURLConnection.java	?	93.42%	?
InstrumentApacheHttpResponseHandler.java	?	100.00%	?
InstrumentOkHttpEnqueueCallback.java	?	100.00%	?
InstrURLConnectionBase.java	?	94.86%	?
LogWrapper.java	?	23.08%	?
MemoryGaugeCollector.java	?	91.38%	?
NetworkConnectionInfo.java	?	0.00%	?
NetworkConnectionInfoOrBuilder.java	?	0.00%	?
NetworkRequestMetric.java	?	49.16%	?
NetworkRequestMetricBuilder.java	?	95.97%	?
NetworkRequestMetricBuilderUtil.java	?	75.00%	?
NetworkRequestMetricOrBuilder.java	?	0.00%	?
Optional.java	?	86.67%	?
PendingPerfEvent.java	?	100.00%	?
PerfMetric.java	?	33.67%	?
PerfMetricOrBuilder.java	?	0.00%	?
PerfMetricValidator.java	?	93.55%	?
PerfSession.java	?	93.22%	?
PerfSessionOrBuilder.java	?	0.00%	?
Rate.java	?	100.00%	?
RateLimiter.java	?	91.73%	?
RemoteConfigManager.java	?	92.86%	?
ResourceType.java	?	0.00%	?
ScreenTraceUtil.java	?	94.12%	?
SessionAwareObject.java	?	0.00%	?
SessionManager.java	?	100.00%	?
SessionVerbosity.java	?	68.42%	?
StorageUnit.java	?	57.89%	?
Timer.java	?	93.75%	?
Trace.java	?	96.67%	?
TraceMetric.java	?	43.14%	?
TraceMetricBuilder.java	?	100.00%	?
TraceMetricOrBuilder.java	?	0.00%	?
TransportInfo.java	?	0.00%	?
TransportInfoOrBuilder.java	?	0.00%	?
TransportManager.java	?	94.88%	?
URLAllowlist.java	?	94.44%	?
URLWrapper.java	?	0.00%	?
Utils.java	?	78.57%	?

Test Logs

Notes

Commit (6cec01a) is created by Prow via merging PR base commit (75ea92c) and head commit (951df8a).
Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

https://storage.googleapis.com/firebase-sdk-metric-reports/dj6uFwMFUg.html

Use the more common stdlib dep now that we ship java8 bytecode.

951df8a

Additionally fix pom dependency type resolution.

vkryachko requested review from rlazo and thatfiredev and removed request for rlazo August 17, 2022 14:36

google-oss-bot added the size/M label Aug 17, 2022

rlazo approved these changes Aug 17, 2022

View reviewed changes

thatfiredev approved these changes Aug 17, 2022

View reviewed changes

vkryachko merged commit eb4d215 into master Aug 17, 2022

vkryachko deleted the vk.stdlib_dep branch August 17, 2022 15:06

firebase locked and limited conversation to collaborators Sep 17, 2022

Use the more common stdlib dep now that we ship java8 bytecode. #4002

Use the more common stdlib dep now that we ship java8 bytecode. #4002

Uh oh!

Conversation

vkryachko commented Aug 17, 2022

Uh oh!

github-actions bot commented Aug 17, 2022

buildSrc Test Results

Uh oh!

github-actions bot commented Aug 17, 2022

Unit Test Results

Uh oh!

thatfiredev commented Aug 17, 2022

Uh oh!

vkryachko commented Aug 17, 2022

Uh oh!

vkryachko commented Aug 17, 2022

Uh oh!

vkryachko commented Aug 17, 2022

Uh oh!

google-oss-bot commented Aug 17, 2022

Size Report 1

Affected Products

firebase-appcheck-ktx

firebase-appdistribution-api-ktx

firebase-config-ktx

firebase-crashlytics-ktx

firebase-database-ktx

firebase-dynamic-links-ktx

firebase-functions-ktx

firebase-inappmessaging-display-ktx

firebase-inappmessaging-ktx

firebase-installations-ktx

firebase-messaging-ktx

firebase-ml-modeldownloader-ktx

firebase-perf-ktx

firebase-storage-ktx

Test Logs

Notes

Uh oh!

thatfiredev commented Aug 17, 2022

Uh oh!

google-oss-bot commented Aug 17, 2022

Coverage Report 1

Affected Products

firebase-common

firebase-database

firebase-firestore

firebase-perf

Test Logs

Notes

Uh oh!

Uh oh!

Size Report ¹

`firebase-appcheck-ktx`

`firebase-appdistribution-api-ktx`

`firebase-config-ktx`

`firebase-crashlytics-ktx`

`firebase-database-ktx`

`firebase-dynamic-links-ktx`

`firebase-functions-ktx`

`firebase-inappmessaging-display-ktx`

`firebase-inappmessaging-ktx`

`firebase-installations-ktx`

`firebase-messaging-ktx`

`firebase-ml-modeldownloader-ktx`

`firebase-perf-ktx`

`firebase-storage-ktx`

Coverage Report ¹

`firebase-common`

`firebase-database`

`firebase-firestore`

`firebase-perf`