Skip to content

add FirebaseAppCheckKtxRegistrar to appcheck-ktx #4003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

thatfiredev
Copy link
Member

This PR should add the missing KtxRegistrar to appcheck-ktx

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 17, 2022

Coverage Report 1

Affected Products

No changes between base commit (d40db69) and merge commit (c8b4daa).

Test Logs

Notes

  • Commit (c8b4daa) is created by Prow via merging PR base commit (d40db69) and head commit (9080c15).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dFPEof5bZG.html

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2022

Unit Test Results

0 files   -    391  0 suites   - 391   0s ⏱️ - 45m 56s
0 tests  - 4 707  0 ✔️  - 4 652  0 💤  - 22  0  - 33 
0 runs   - 4 723  0 ✔️  - 4 668  0 💤  - 22  0  - 33 

Results for commit 9080c15. ± Comparison against base commit eb4d215.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 17, 2022

Size Report 1

Affected Products

  • firebase-appcheck-ktx

    TypeBase (d40db69)Merge (c8b4daa)Diff
    aar5.60 kB6.44 kB+839 B (+15.0%)
    apk (aggressive)350 kB351 kB+88 B (+0.0%)
    apk (release)1.52 MB1.52 MB+232 B (+0.0%)

Test Logs

Notes

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qBgpllHTBH.html

Copy link
Member

@vkryachko vkryachko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍

One minor nit below

@google-oss-bot
Copy link
Contributor

@thatfiredev: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 9080c15 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vkryachko vkryachko merged commit eefb794 into master Aug 17, 2022
@vkryachko vkryachko deleted the rpf-add-fac-ktx-registrar branch August 17, 2022 18:01
@firebase firebase locked and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants