Skip to content

Prevent gradle daemon from crashing #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Prevent gradle daemon from crashing #4016

merged 1 commit into from
Aug 23, 2022

Conversation

yifanyang
Copy link
Contributor

@yifanyang yifanyang commented Aug 22, 2022

Smoke tests have been occasionally failing due to:

FAILURE: Build failed with an exception.

* What went wrong:
Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)

This pull request seems to fix the issue. With the change in this pull request, the above error does not appear in any of the 5 total runs of smoke tests (see attempt 1-5 of https://github.com/firebase/firebase-android-sdk/actions/runs/2905798357).

@github-actions
Copy link
Contributor

Unit Test Results

   392 files  +   364     392 suites  +364   16m 26s ⏱️ + 15m 23s
4 708 tests +4 395  4 686 ✔️ +4 374  22 💤 +21  0 ±0 
4 724 runs  +4 411  4 702 ✔️ +4 390  22 💤 +21  0 ±0 

Results for commit 8a77d16. ± Comparison against base commit 58c1677.

@google-oss-bot
Copy link
Contributor

@yifanyang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 8a77d16 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (58c1677) and merge commit (d55ca38).

Test Logs

Notes

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xmdL2k3206.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-common

    Overall coverage changed from ? (58c1677) to 66.44% (d55ca38) by ?.

    32 individual files with coverage change

    FilenameBase (58c1677)Merge (d55ca38)Diff
    AutoValue_HeartBeatResult.java?33.33%?
    AutoValue_LibraryVersion.java?58.33%?
    AutoValue_SdkHeartBeatResult.java?0.00%?
    ComponentDiscoveryService.java?0.00%?
    ComponentMonitor.java?100.00%?
    DataCollectionConfigStorage.java?88.89%?
    DataCollectionDefaultChange.java?100.00%?
    DefaultHeartBeatController.java?94.03%?
    DefaultUserAgentPublisher.java?95.45%?
    EmulatedServiceSettings.java?0.00%?
    FirebaseApp.java?55.71%?
    FirebaseAppLifecycleListener.java?0.00%?
    FirebaseCommonRegistrar.java?95.74%?
    FirebaseError.java?0.00%?
    FirebaseInitProvider.java?58.82%?
    FirebaseNetworkException.java?0.00%?
    FirebaseOptions.java?31.94%?
    FirebaseTooManyRequestsException.java?0.00%?
    FirebaseTrace.java?100.00%?
    GlobalLibraryVersionRegistrar.java?75.00%?
    HeartBeatConsumer.java?0.00%?
    HeartBeatConsumerComponent.java?0.00%?
    HeartBeatController.java?0.00%?
    HeartBeatInfo.java?100.00%?
    HeartBeatInfoStorage.java?90.57%?
    HeartBeatResult.java?100.00%?
    KotlinDetector.java?66.67%?
    LibraryVersion.java?100.00%?
    LibraryVersionComponent.java?100.00%?
    PublicApi.java?0.00%?
    SdkHeartBeatResult.java?0.00%?
    UserAgentPublisher.java?0.00%?

  • firebase-database

    Overall coverage changed from 50.17% (58c1677) to 50.14% (d55ca38) by -0.03%.

    FilenameBase (58c1677)Merge (d55ca38)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
    QueryParams.java89.76%90.36%+0.60%
  • firebase-firestore

    Overall coverage changed from 46.01% (58c1677) to 46.02% (d55ca38) by +0.01%.

    FilenameBase (58c1677)Merge (d55ca38)Diff
    Datastore.java29.76%32.14%+2.38%
  • firebase-messaging

    Overall coverage changed from ? (58c1677) to 84.96% (d55ca38) by ?.

    41 individual files with coverage change

    FilenameBase (58c1677)Merge (d55ca38)Diff
    AutoProtoEncoderDoNotUseEncoder.java?98.17%?
    ByteStreams.java?59.72%?
    CommonNotificationBuilder.java?90.38%?
    Constants.java?92.86%?
    DisplayNotification.java?91.38%?
    EnhancedIntentService.java?76.60%?
    ExecutorFactory.java?0.00%?
    FcmBroadcastProcessor.java?93.18%?
    FcmExecutors.java?80.00%?
    FcmLifecycleCallbacks.java?89.29%?
    FirebaseInstanceIdReceiver.java?72.73%?
    FirebaseMessaging.java?74.89%?
    FirebaseMessagingRegistrar.java?100.00%?
    FirebaseMessagingService.java?94.03%?
    GmsRpc.java?83.15%?
    ImageDownload.java?93.33%?
    MessagingAnalytics.java?82.19%?
    MessagingClientEvent.java?93.58%?
    MessagingClientEventExtension.java?76.47%?
    Metadata.java?57.14%?
    NotificationParams.java?98.71%?
    PoolableExecutors.java?29.17%?
    ProtoEncoderDoNotUse.java?50.00%?
    ProxyNotificationInitializer.java?93.75%?
    ProxyNotificationPreferences.java?88.89%?
    RemoteMessage.java?95.48%?
    RemoteMessageCreator.java?88.89%?
    RequestDeduplicator.java?90.00%?
    SendException.java?100.00%?
    ServiceStarter.java?87.50%?
    SharedPreferencesQueue.java?98.65%?
    Store.java?74.19%?
    SyncTask.java?70.83%?
    ThreadPriority.java?100.00%?
    TopicOperation.java?90.00%?
    TopicsStore.java?100.00%?
    TopicsSubscriber.java?88.60%?
    TopicsSyncTask.java?49.33%?
    WakeLockHolder.java?96.08%?
    WithinAppServiceBinder.java?90.91%?
    WithinAppServiceConnection.java?84.15%?

Test Logs

Notes

  • Commit (d55ca38) is created by Prow via merging PR base commit (58c1677) and head commit (8a77d16).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/9WkHId64OJ.html

@yifanyang yifanyang marked this pull request as ready for review August 22, 2022 22:45
@yifanyang yifanyang requested a review from vkryachko August 22, 2022 22:53
@yifanyang yifanyang merged commit 04793bc into master Aug 23, 2022
@yifanyang yifanyang deleted the yifany/smoke-gradle branch August 23, 2022 16:47
@firebase firebase locked and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants