Skip to content

Fix robolectric SQLite issue with Apple Silicon #4019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Aug 23, 2022

No description provided.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 46.01% (58c1677) to 46.01% (7eac84d) by -0.00%.

    FilenameBase (58c1677)Merge (7eac84d)Diff
    Datastore.java29.76%32.14%+2.38%
    DeleteMutation.java95.24%90.48%-4.76%
    PatchMutation.java100.00%98.39%-1.61%
    SetMutation.java97.22%94.44%-2.78%

Test Logs

Notes

  • Commit (7eac84d) is created by Prow via merging PR base commit (58c1677) and head commit (fa34f12).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yl3Xing2eS.html

@github-actions
Copy link
Contributor

Unit Test Results

1 096 tests  +783   1 080 ✔️ +768   55s ⏱️ -8s
     78 suites +  50        16 💤 +  15 
     78 files   +  50          0 ±    0 

Results for commit fa34f12. ± Comparison against base commit 58c1677.

This pull request removes 313 and adds 1096 tests. Note that renamed tests count towards both.
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addClickListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addDismissListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addDisplayErrorListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addImpressionListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ automaticDataCollectionDisabling_clearsInDataCollectionHelper
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ automaticDataCollectionDisabling_disablesInDataCollectionHelper
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ automaticDataCollectionEnabling_enablesInDataCollectionHelper
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ clearDisplayListener_removesListener
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ messagesSuppressed_isFalseOnInitialization
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ messagesSuppressed_isTrueWhenUpdated
…
com.google.firebase.TimestampTest ‑ testCompare
com.google.firebase.TimestampTest ‑ testFromDate
com.google.firebase.TimestampTest ‑ testRejectBadDates
com.google.firebase.TimestampTest ‑ testTimestampParcelable
com.google.firebase.firestore.BlobTest ‑ testComparison
com.google.firebase.firestore.BlobTest ‑ testEquals
com.google.firebase.firestore.BlobTest ‑ testMutableBytes
com.google.firebase.firestore.CollectionReferenceTest ‑ testEquals
com.google.firebase.firestore.DocumentChangeTest ‑ randomTests
com.google.firebase.firestore.DocumentChangeTest ‑ testAdditions
…
This pull request removes 1 skipped test and adds 16 skipped tests. Note that renamed tests count towards both.
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ streamListener_onNotifiedCard_showsCardMessage
com.google.firebase.firestore.FirestoreRegistrarTest ‑ storageRegistrar_getComponents_publishesLibVersionComponent
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testDoesNotReplaceResumeTokenWithEmptyByteString
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testHandlesSetMutationThenAckThenTransformThenAckThenTransform
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testIgnoresTargetMappingAfterExistenceFilterMismatch
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testPersistsResumeTokens
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testQueriesFilterDocumentsThatNoLongerMatch
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testQueriesIncludeDocumentsFromOtherQueries
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testQueriesIncludeLocallyModifiedDocuments
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testUsesTargetMappingToExecuteQueries
com.google.firebase.firestore.local.SQLiteLocalStoreTest ‑ testCollectsGarbageAfterAcknowledgedMutation
…

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (58c1677) and merge commit (7eac84d).

Test Logs

Notes

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8TC0AaK3sB.html

@wu-hui wu-hui merged commit d7eac87 into master Aug 23, 2022
@wu-hui wu-hui deleted the wuandy/FixSqliteM1 branch August 23, 2022 17:49
@firebase firebase locked and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants