Skip to content

Fix: Cannot mark as impressed more than one message almost same time #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public class DisplayCallbacksImpl implements FirebaseInAppMessagingDisplayCallba
private final InAppMessage inAppMessage;
private final String triggeringEvent;

private static boolean wasImpressed;
private boolean wasImpressed;
private static final String MESSAGE_CLICK = "message click to metrics logger";

@VisibleForTesting
Expand Down Expand Up @@ -72,6 +72,11 @@ public class DisplayCallbacksImpl implements FirebaseInAppMessagingDisplayCallba
wasImpressed = false;
}

@VisibleForTesting
boolean wasImpressed() {
return wasImpressed;
}

@Override
public Task<Void> impressionDetected() {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,27 @@ public void logImpression_forVanillaCampaign_recordsImpression() {
assertThat(wasRecorded).isTrue();
}

@Test
public void logImpression_forOneMessageShouldNotAffectOtherMessages() {
FirebaseInAppMessagingDisplayCallbacks displayCallbacksImplOne =
displayCallbacksFactory.generateDisplayCallback(
BANNER_TEST_MESSAGE_MODEL, ANALYTICS_EVENT_NAME);

FirebaseInAppMessagingDisplayCallbacks displayCallbacksImplTwo =
displayCallbacksFactory.generateDisplayCallback(
BANNER_TEST_MESSAGE_MODEL, ANALYTICS_EVENT_NAME);

displayCallbacksImplOne.impressionDetected();

assertThat(((DisplayCallbacksImpl) displayCallbacksImplOne).wasImpressed()).isTrue();
assertThat(((DisplayCallbacksImpl) displayCallbacksImplTwo).wasImpressed()).isFalse();

displayCallbacksImplTwo.impressionDetected();

assertThat(((DisplayCallbacksImpl) displayCallbacksImplOne).wasImpressed()).isTrue();
assertThat(((DisplayCallbacksImpl) displayCallbacksImplTwo).wasImpressed()).isTrue();
}

@Test
public void logImpression_forTestCampaign_doesRecordImpression() {
displayCallbacksImpl =
Expand Down