Remove Dokka Plugin #4031
Merged
Remove Dokka Plugin #4031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't currently need to be public, as it automatically gets applied via FirebaseLibrary.
Now that the Dackka plugin is implemented, we can safely remove our previous Dokka plugin.
Size Report 1Affected ProductsNo changes between base commit (f721dbc) and merge commit (3d9d42f).Test Logs
Notes |
Coverage Report 1Affected Products
Test Logs
Notes |
vkryachko
reviewed
Aug 25, 2022
|
please check buildSrc failures, look legit |
vkryachko
reviewed
Sep 7, 2022
vkryachko
approved these changes
Sep 8, 2022
qdpham13
pushed a commit
that referenced
this pull request
Sep 13, 2022
* Remove DackkaPlugin from register block This doesn't currently need to be public, as it automatically gets applied via FirebaseLibrary. * Remove Dokka Pugin Now that the Dackka plugin is implemented, we can safely remove our previous Dokka plugin. * Added empty kotlindoc to JavaPlugin for tests * Removed Dokka from JavadocPlugin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per b/243685887, now that Dackka has been implemented- we can safely remove the old Dokka plugin.
We also don't need to register the DackkaPlugin, as it automatically gets applied via
FirebaseLibrary. Unless we end up having a use case where consumers want/or need to manually apply the plugin- exposing it this way could open the door to misunderstandings & bugs. This PR removes it to be safe.