Skip to content

Move external documentation links to a task input in Dackka #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 7, 2022
Merged

Move external documentation links to a task input in Dackka #4033

merged 5 commits into from
Sep 7, 2022

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Aug 25, 2022

Per b/243675474, this moves the external links argument in Dokka to a task input in GenerateDocumentationTask. This will allow the files to not only be cached- but monitored for changes.

Also added some gradle caching annotations to GenerateDocumentationTaskExtension, to allow the task to fully take advantage of gradle's cache.

@daymxn
Move external links in dackka to an input
7c5ac66 
This will allow the package-list files to be cached, and monitored for updates.
@daymxn daymxn requested review from vkryachko and rlazo August 25, 2022 20:19
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022 •
edited
Loading

buildSrc Test Results

18 tests   18 ✔️  2m 33s ⏱️
  4 suites    0 💤
  4 files      0 ❌

Results for commit ebb9b95.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 25, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (7c5ef93) and merge commit (a3c89db).

Test Logs

Notes

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NvdPzfHTyy.html

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022 •
edited
Loading

Unit Test Results

   394 files  ±0     394 suites  ±0   17m 52s ⏱️ - 3m 24s
4 717 tests ±0  4 695 ✔️ ±0  22 💤 ±0  0 ❌ ±0 
4 733 runs  ±0  4 711 ✔️ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit ebb9b95. ± Comparison against base commit 7c5ef93.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 25, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.33% (7c5ef93) to 44.33% (a3c89db) by +0.00%.

    FilenameBase (7c5ef93)Merge (a3c89db)Diff
    DeleteMutation.java90.48%95.24%+4.76%

  • firebase-messaging

    Overall coverage changed from ? (7c5ef93) to 85.26% (a3c89db) by ?.

    41 individual files with coverage change

    FilenameBase (7c5ef93)Merge (a3c89db)Diff
    AutoProtoEncoderDoNotUseEncoder.java?98.17%?
    ByteStreams.java?59.72%?
    CommonNotificationBuilder.java?90.78%?
    Constants.java?92.86%?
    DisplayNotification.java?91.38%?
    EnhancedIntentService.java?76.60%?
    ExecutorFactory.java?0.00%?
    FcmBroadcastProcessor.java?93.33%?
    FcmExecutors.java?80.00%?
    FcmLifecycleCallbacks.java?89.29%?
    FirebaseInstanceIdReceiver.java?72.73%?
    FirebaseMessaging.java?76.21%?
    FirebaseMessagingRegistrar.java?100.00%?
    FirebaseMessagingService.java?94.03%?
    GmsRpc.java?83.15%?
    ImageDownload.java?93.33%?
    MessagingAnalytics.java?82.19%?
    MessagingClientEvent.java?93.58%?
    MessagingClientEventExtension.java?76.47%?
    Metadata.java?57.14%?
    NotificationParams.java?98.71%?
    PoolableExecutors.java?29.17%?
    ProtoEncoderDoNotUse.java?50.00%?
    ProxyNotificationInitializer.java?93.75%?
    ProxyNotificationPreferences.java?88.89%?
    RemoteMessage.java?95.48%?
    RemoteMessageCreator.java?88.89%?
    RequestDeduplicator.java?90.00%?
    SendException.java?100.00%?
    ServiceStarter.java?87.50%?
    SharedPreferencesQueue.java?98.65%?
    Store.java?74.19%?
    SyncTask.java?70.83%?
    ThreadPriority.java?100.00%?
    TopicOperation.java?90.00%?
    TopicsStore.java?100.00%?
    TopicsSubscriber.java?89.47%?
    TopicsSyncTask.java?53.33%?
    WakeLockHolder.java?96.08%?
    WithinAppServiceBinder.java?90.91%?
    WithinAppServiceConnection.java?84.15%?

  • firebase-ml-modeldownloader

    Overall coverage changed from ? (7c5ef93) to 83.95% (a3c89db) by ?.

    20 individual files with coverage change

    FilenameBase (7c5ef93)Merge (a3c89db)Diff
    AutoFirebaseMlLogEventEncoder.java?100.00%?
    AutoValue_FirebaseMlLogEvent.java?58.18%?
    AutoValue_FirebaseMlLogEvent_DeleteModelLogEvent.java?66.67%?
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent.java?65.82%?
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent_ModelOptions.java?62.96%?
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent_ModelOptions_ModelInfo.java?64.58%?
    AutoValue_FirebaseMlLogEvent_SystemInfo.java?63.38%?
    CustomModel.java?73.02%?
    CustomModelDownloadConditions.java?88.46%?
    CustomModelDownloadService.java?81.46%?
    DataTransportMlEventSender.java?100.00%?
    DownloadType.java?100.00%?
    FirebaseMlException.java?100.00%?
    FirebaseMlLogEvent.java?97.92%?
    FirebaseMlLogger.java?87.93%?
    FirebaseModelDownloader.java?85.21%?
    FirebaseModelDownloaderRegistrar.java?94.87%?
    ModelFileDownloadService.java?90.80%?
    ModelFileManager.java?82.72%?
    SharedPreferencesUtil.java?97.24%?

Test Logs

Notes

  • Commit (a3c89db) is created by Prow via merging PR base commit (7c5ef93) and head commit (ebb9b95).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qD2Ttg0UHv.html

@daymxn
Copy link
Member Author

daymxn commented Sep 6, 2022

/retest

@daymxn
Copy link
Member Author

daymxn commented Sep 7, 2022

/retest

@daymxn daymxn merged commit 59286c6 into master Sep 7, 2022
@daymxn daymxn deleted the daymon-external-links-to-task-input-dackka branch September 7, 2022 21:16
qdpham13 pushed a commit that referenced this pull request Sep 13, 2022
@daymxn @qdpham13
Move external documentation links to a task input in Dackka (#4033)
b159f27 
* Move external links in dackka to an input

This will allow the package-list files to be cached, and monitored for updates.

* Maybe fixed merge conflict

* Fixed formatting

* Removed duplicate configurations
@firebase firebase locked and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

@rlazo rlazo Awaiting requested review from rlazo

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daymxn @google-oss-bot @vkryachko