Skip to content

Implement Metalava with Dackka #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Sep 6, 2022

Per b/243941807, this refactors the Dackka task to utilize Metalava generated stubs for Java sources, and use the standard sources for Kotlin.

This also adds a small extension method for Metalava, since we don't actually offer configuration of the output directory on stub generation.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

buildSrc Test Results

18 tests   18 ✔️  2m 12s ⏱️
  4 suites    0 💤
  4 files      0

Results for commit bed1f87.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (ffd44ee) and merge commit (2aeb769).

Test Logs

Notes

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/to0w0xhrHC.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.17% (ffd44ee) to 50.13% (2aeb769) by -0.04%.

    FilenameBase (ffd44ee)Merge (2aeb769)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
  • firebase-firestore

    Overall coverage changed from 44.32% (ffd44ee) to 44.42% (2aeb769) by +0.10%.

    FilenameBase (ffd44ee)Merge (2aeb769)Diff
    AsyncQueue.java78.11%78.61%+0.50%
    Datastore.java21.55%23.28%+1.72%
    FirestoreChannel.java16.38%18.10%+1.72%
    FirestoreClient.java31.25%36.11%+4.86%
    GrpcCallProvider.java62.35%69.41%+7.06%
    IndexBackfiller.java89.06%93.75%+4.69%
    LruGarbageCollector.java90.65%93.46%+2.80%
    SetMutation.java94.44%97.22%+2.78%
    SQLitePersistence.java86.89%86.34%-0.55%

Test Logs

Notes

  • Commit (2aeb769) is created by Prow via merging PR base commit (ffd44ee) and head commit (bed1f87).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AvHAZGYQFf.html

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Unit Test Results

   394 files  +   343     394 suites  +343   32m 47s ⏱️ + 30m 57s
4 717 tests +3 741  4 695 ✔️ +3 719  22 💤 +22  0 ±0 
4 733 runs  +3 757  4 711 ✔️ +3 735  22 💤 +22  0 ±0 

Results for commit bed1f87. ± Comparison against base commit ffd44ee.

♻️ This comment has been updated with latest results.

@daymxn daymxn merged commit 7c5ef93 into master Sep 6, 2022
@daymxn daymxn deleted the daymon-add-stub-support-to-dackka branch September 6, 2022 21:46
qdpham13 pushed a commit that referenced this pull request Sep 13, 2022
@firebase firebase locked and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants