Skip to content

Properly encode http params. #4065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2022
Merged

Properly encode http params. #4065

merged 1 commit into from
Sep 7, 2022

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Sep 7, 2022

Properly encode http params. This should resolve #4060 where special characters were not being encoded.

Should we consider using a typical http library instead of this custom built network package?

@mrober mrober requested a review from mrichards September 7, 2022 18:23
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-crashlytics

    Overall coverage changed from 10.19% (7c5ef93) to 10.18% (ca183d5) by -0.01%.

Test Logs

Notes

  • Commit (ca183d5) is created by Prow via merging PR base commit (7c5ef93) and head commit (4902ba0).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1cj2YLgRxF.html

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Unit Test Results

  3 files   -    391    3 suites   - 391   11s ⏱️ - 21m 5s
18 tests  - 4 699  18 ✔️  - 4 677  0 💤  - 22  0 ❌ ±0 
18 runs   - 4 715  18 ✔️  - 4 693  0 💤  - 22  0 ❌ ±0 

Results for commit 4902ba0. ± Comparison against base commit 7c5ef93.

@google-oss-bot
Copy link
Contributor

@mrober: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 4902ba0 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-crashlytics

    TypeBase (7c5ef93)Merge (ca183d5)Diff
    aar341 kB341 kB+67 B (+0.0%)
    apk (aggressive)217 kB217 kB-4 B (-0.0%)
    apk (release)905 kB905 kB+60 B (+0.0%)

Test Logs

Notes

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kQQNWBIJJr.html

mrichards
mrichards approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@mrichards mrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree we should consider moving to a built-in network library at some point soon, but this seems like a great stopgap.

@mrober mrober merged commit f721dbc into master Sep 7, 2022
@mrober mrober deleted the crashlytics-params branch September 7, 2022 19:18
qdpham13 pushed a commit that referenced this pull request Sep 13, 2022
@mrober @qdpham13
Properly encode http params. (#4065)
6a36cc5
@firebase firebase locked and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrichards mrichards mrichards approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"E/FirebaseCrashlytics: Settings request failed. java.io.FileNotFoundException when build versionName contains spaces
3 participants
@mrober @google-oss-bot @mrichards