Skip to content

Make dackka task depend on docStubs task. #4072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2022
Merged

Make dackka task depend on docStubs task. #4072

merged 3 commits into from
Sep 9, 2022

Conversation

vkryachko
Copy link
Member

Otherwise no docs are produced for java sdks.

@vkryachko
Make dackka task depend on docStubs task.
63bbec5 
Otherwise no docs are produced for java sdks.
@vkryachko vkryachko requested a review from daymxn September 9, 2022 14:13
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 9, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (005fc6b) and merge commit (7ced461).

Test Logs

Notes

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/SU8P7bMtVJ.html

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Unit Test Results

   394 files  ±0     394 suites  ±0   16m 58s ⏱️ - 32m 11s
4 717 tests ±0  4 695 ✔️ +33  22 💤 ±0  0 ❌  - 33 
4 733 runs  ±0  4 711 ✔️ +33  22 💤 ±0  0 ❌  - 33 

Results for commit f599591. ± Comparison against base commit 005fc6b.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 9, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.17% (005fc6b) to 50.13% (7ced461) by -0.04%.

    FilenameBase (005fc6b)Merge (7ced461)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%

  • firebase-firestore

    Overall coverage changed from 44.32% (005fc6b) to 44.41% (7ced461) by +0.09%.

    FilenameBase (005fc6b)Merge (7ced461)Diff
    AsyncQueue.java78.11%78.61%+0.50%
    Datastore.java21.55%23.28%+1.72%
    FirestoreClient.java31.25%36.11%+4.86%
    GrpcCallProvider.java62.35%69.41%+7.06%
    IndexBackfiller.java89.06%93.75%+4.69%
    LruGarbageCollector.java90.65%93.46%+2.80%
    SQLitePersistence.java86.34%86.89%+0.55%

  • firebase-messaging

    Overall coverage changed from 85.26% (005fc6b) to 84.91% (7ced461) by -0.35%.

    FilenameBase (005fc6b)Merge (7ced461)Diff
    FirebaseMessaging.java75.77%74.89%-0.88%
    Metadata.java61.90%57.14%-4.76%
    TopicsSubscriber.java89.47%88.60%-0.88%
    TopicsSyncTask.java53.33%49.33%-4.00%

  • firebase-storage

    Overall coverage changed from 86.37% (005fc6b) to 86.24% (7ced461) by -0.13%.

    FilenameBase (005fc6b)Merge (7ced461)Diff
    NetworkRequest.java87.18%86.67%-0.51%
    UploadTask.java83.09%82.37%-0.72%

Test Logs

Notes

  • Commit (7ced461) is created by Prow via merging PR base commit (005fc6b) and head commit (a30600f).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Rol8aFtQU1.html

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

buildSrc Test Results

18 tests   18 ✔️  2m 20s ⏱️
  4 suites    0 💤
  4 files      0 ❌

Results for commit a30600f.

@vkryachko vkryachko merged commit d50a3d1 into master Sep 9, 2022
@vkryachko vkryachko deleted the vk.dackka_dep_fix branch September 9, 2022 15:08
@google-oss-bot
Copy link
Contributor

@vkryachko: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed a30600f link /test check-changed
smoke-tests a30600f link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

daymxn
daymxn reviewed Sep 9, 2022
View reviewed changes
buildSrc/src/main/java/com/google/firebase/gradle/plugins/DackkaPlugin.kt
// this will become useful with the agp upgrade, as they're separate in 7.x+
val sourcesForKotlin = emptyList<File>()
val packageLists = fetchPackageLists(project)

if (!isKotlin) dependsOn(docStubs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Ideally we should switch this to dependsOnAndMustRunAfter in the future, but it's not breaking for now.

qdpham13 pushed a commit that referenced this pull request Sep 13, 2022
@vkryachko @qdpham13
Make dackka task depend on docStubs task. (#4072)
dd12c0f 
* Make dackka task depend on docStubs task.

Otherwise no docs are produced for java sdks.

* Fix toc.yaml path.

* Fix tests and dgc url.
@firebase firebase locked and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daymxn daymxn daymxn left review comments

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkryachko @google-oss-bot @rlazo @daymxn