Skip to content

Add a screenshot-based trigger for in-app feedback #4122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 27, 2022
Merged

Add a screenshot-based trigger for in-app feedback #4122

merged 9 commits into from
Sep 27, 2022

Conversation

lfkellogg
Copy link
Contributor

Also has some refactoring to, among other things, allow the passing of a screenshot URI to the startFeedback() API.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 20, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from 76.50% (eb9414a) to 76.42% (362f730) by -0.08%.

    FilenameBase (eb9414a)Merge (362f730)Diff
    AutoValue_ImageUtils_ImageSize.java30.00%35.00%+5.00%
    FirebaseAppDistributionImpl.java92.86%92.31%-0.55%
    ImageUtils.java95.45%96.00%+0.55%
    LogWrapper.java53.33%62.50%+9.17%
    ScreenshotTaker.java65.63%66.67%+1.04%
    TesterApiHttpClient.java89.19%89.47%+0.28%

  • firebase-appdistribution-api

    Overall coverage changed from 60.91% (eb9414a) to 57.76% (362f730) by -3.15%.

    FilenameBase (eb9414a)Merge (362f730)Diff
    FirebaseAppDistributionProxy.java73.33%57.89%-15.44%
    FirebaseAppDistributionStub.java79.55%76.09%-3.46%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mu3NEbHYz5.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-appdistribution-api:
error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(CharSequence,android.net.Uri) [AddedAbstractMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@lfkellogg lfkellogg force-pushed the lk/screenshot-trigger branch 2 times, most recently from 3575037 to 7233fc1 Compare September 22, 2022 19:09
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-appdistribution-api:
error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(CharSequence,android.net.Uri) [AddedAbstractMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 22, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (eb9414a)Merge (362f730)Diff
    aar153 kB154 kB+1.49 kB (+1.0%)
    apk (aggressive)881 kB882 kB+856 B (+0.1%)
    apk (release)2.01 MB2.01 MB+960 B (+0.0%)

  • firebase-appdistribution-api

    TypeBase (eb9414a)Merge (362f730)Diff
    aar14.4 kB14.7 kB+247 B (+1.7%)
    apk (release)689 kB689 kB+260 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PniBF34GOU.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-appdistribution-api:
error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(CharSequence,android.net.Uri) [AddedAbstractMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@lfkellogg lfkellogg requested a review from kaibolay September 23, 2022 13:21
@lfkellogg lfkellogg force-pushed the lk/screenshot-trigger branch from 06eb491 to c1215a9 Compare September 23, 2022 13:22
@lfkellogg lfkellogg changed the title WIP - Add a screenshot-based trigger for in-app feedback Add a screenshot-based trigger for in-app feedback Sep 23, 2022
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-appdistribution-api:
error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(CharSequence,android.net.Uri) [AddedAbstractMethod]
error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(int,android.net.Uri) [AddedAbstractMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@lfkellogg lfkellogg force-pushed the lk/screenshot-trigger branch from c1215a9 to c6f2661 Compare September 23, 2022 13:30
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-appdistribution-api:
error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(CharSequence,android.net.Uri) [AddedAbstractMethod]
error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(int,android.net.Uri) [AddedAbstractMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

1 similar comment
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-appdistribution-api:
error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(CharSequence,android.net.Uri) [AddedAbstractMethod]
error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.startFeedback(int,android.net.Uri) [AddedAbstractMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

kaibolay
kaibolay reviewed Sep 23, 2022
View reviewed changes
kaibolay
kaibolay approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@kaibolay kaibolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge with remaining TODOs - they can be addressed in a follow-up

kaibolay
kaibolay approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@kaibolay kaibolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks!

@lfkellogg lfkellogg force-pushed the lk/screenshot-trigger branch from 3ae5c08 to 5d66a9a Compare September 26, 2022 22:18
@lfkellogg lfkellogg merged commit fe657de into fad/in-app-feedback Sep 27, 2022
@lfkellogg lfkellogg deleted the lk/screenshot-trigger branch September 27, 2022 12:55
@firebase firebase locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaibolay kaibolay kaibolay approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfkellogg @google-oss-bot @kaibolay