Skip to content

Make count queries publicly available for use #4126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Make count queries publicly available for use #4126

wants to merge 4 commits into from

Conversation

dconeybe
Copy link
Contributor

This PR changes the visibility of classes and methods that provide "count" queries from default to public, making them available for anyone to use. See #3847 for the implementation of COUNT queries.

@dconeybe dconeybe self-assigned this Sep 22, 2022
@dconeybe dconeybe changed the title Dconeybe/count release Make count queries publicly available for use Sep 22, 2022
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 22, 2022 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (ed10eb5) and merge commit (e1eedf7).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YveUwXshFv.html

@dconeybe dconeybe changed the base branch from master to dconeybe/CountFixApisToMatchProposal September 22, 2022 05:58
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 22, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (ed10eb5)Merge (e1eedf7)Diff
    aar1.30 MB1.30 MB-52 B (-0.0%)
    apk (release)3.32 MB3.32 MB-104 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/X3KibSJu9Q.html

@github-actions
Copy link
Contributor

Unit Test Results

     79 files   -    311       79 suites   - 311   1m 0s ⏱️ - 17m 1s
1 097 tests  - 3 603  1 081 ✔️  - 3 595  16 💤  - 6  0 ❌  - 2 
1 097 runs   - 3 619  1 081 ✔️  - 3 611  16 💤  - 6  0 ❌  - 2 

Results for commit 67dbe2b. ± Comparison against base commit ed10eb5.

@dconeybe
Copy link
Contributor Author

#4130

@dconeybe dconeybe closed this Sep 22, 2022
@dconeybe dconeybe deleted the dconeybe/CountRelease branch September 22, 2022 16:01
@firebase firebase locked and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@dconeybe dconeybe

Labels
api: firestore do-not-merge/work-in-progress size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dconeybe @google-oss-bot