Skip to content

Fix links in FeedbackActivity info text #4133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Fix links in FeedbackActivity info text #4133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb4de30
Fix links in FeedbackActivity info text
lfkellogg Sep 22, 2022
dfaaba7
Add TODO about adding a test for <a> tags in info text
lfkellogg Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...n/src/main/java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,9 @@ private UpdateTask updateApp(boolean showDownloadInNotificationManager) {

@Override
public void startFeedback(int infoTextResourceId) {
startFeedback(firebaseApp.getApplicationContext().getString(infoTextResourceId));
// TODO(lkellogg): Once we have the real FeedbackActivity view implemented, we should write a
// test that checks that <a> tags are preserved
startFeedback(firebaseApp.getApplicationContext().getText(infoTextResourceId));
}

@VisibleForTesting
Expand Down