Skip to content

Only allow one feedback flow to be active #4137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2022
Merged

Only allow one feedback flow to be active #4137

merged 2 commits into from
Sep 27, 2022

Conversation

lfkellogg
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 22, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from 76.42% (d91d9aa) to 78.16% (8ba87da) by +1.74%.

    FilenameBase (d91d9aa)Merge (8ba87da)Diff
    FeedbackActivity.java0.00%1.89%+1.89%
    FirebaseAppDistributionImpl.java92.31%94.29%+1.98%
    FirebaseAppDistributionLifecycleNotifier.java75.00%98.00%+23.00%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/P35aBZysUA.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 22, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (d91d9aa)Merge (6350c3e)Diff
    aar154 kB154 kB+301 B (+0.2%)
    apk (aggressive)882 kB882 kB+8 B (+0.0%)
    apk (release)2.01 MB2.01 MB+120 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/F2JO0WvMCK.html

@lfkellogg lfkellogg requested a review from kaibolay September 27, 2022 14:56
kaibolay
kaibolay approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@kaibolay kaibolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lfkellogg lfkellogg force-pushed the lk/only-one-feedback branch 2 times, most recently from 090788b to 1d3501f Compare September 27, 2022 16:04
@lfkellogg lfkellogg merged commit 11ce2cd into fad/in-app-feedback Sep 27, 2022
@lfkellogg lfkellogg deleted the lk/only-one-feedback branch September 27, 2022 17:13
@firebase firebase locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaibolay kaibolay kaibolay approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfkellogg @google-oss-bot @kaibolay