Add shake for feedback to test app #4138
Conversation
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
lfkellogg
force-pushed
the
lk/shake-for-feedback
branch
from
335ac81 to
59d4b55
Compare
lfkellogg
force-pushed
the
lk/shake-for-feedback
branch
from
59d4b55 to
fcc4fe8
Compare
| import android.app.Application | ||
|
|
||
| class AppDistroTestApplication : Application() { | ||
| override fun onCreate() { |
There was a problem hiding this comment.
Unrelated to this PR, but should we move more initialization code from MainActiviry.onCreate() to here?
Also, I'm curious: Would this also work if we added it to MainActivity.onCreate()?
There was a problem hiding this comment.
Unrelated to this PR, but should we move more initialization code from MainActiviry.onCreate() to here?
Yes I think so. I'm interested in trying to make the screenshot trigger work this way: you enable it in the Application class, and then it listens to lifecycle callbacks and attached to each Activity as it starts.
Also, I'm curious: Would this also work if we added it to MainActivity.onCreate()?
If we just picked this up and moved it there, then you run the risk of calling enable() multiple times if there are other activities in the app. I believe that would register multiple lifecycle callbacks on the Application. We could prevent that from happening by only allowing it to be enabled once. But I think it makes sense to initialize this in the Application since it enables application-wide functionality.
There was a problem hiding this comment.
Ah, makes sense. Let's explore moving the initialization code here in a separate PR once this one is merged.
Also, I think we should restore the button to launch the second activity so we can test those scenarios. Maybe you can do that when adding the radio buttons.
...n/test-app/src/main/java/com/googletest/firebase/appdistribution/testapp/ShakeForFeedback.kt
Show resolved
Hide resolved
No description provided.