Skip to content

Some fixes to the test app's screenshot detection trigger #4145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 27, 2022

Conversation

lfkellogg
Copy link
Contributor

  • Catch SecurityException for when we don't have access to the screenshot anymore
  • Don't crash when trying to read images in the "pending" state
  • Prevent us from requesting permissions multiple times in a row

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 26, 2022

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 26, 2022

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (fe657de)Merge (849c20b)Diff
    aar154 kB154 kB+15 B (+0.0%)
    apk (aggressive)882 kB882 kB-8 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/X3hjopNUtw.html

Base automatically changed from lk/screenshot-trigger to fad/in-app-feedback September 27, 2022 12:55
@kaibolay
Copy link
Contributor

I resolved the merge conflict. Please check if I did it correctly and merge if I did - otherwise please accept my apologies.

@lfkellogg lfkellogg merged commit d91d9aa into fad/in-app-feedback Sep 27, 2022
@lfkellogg lfkellogg deleted the lk/wait-for-pending-screenshots branch September 27, 2022 15:02
@firebase firebase locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants