-
Notifications
You must be signed in to change notification settings - Fork 624
Some fixes to the test app's screenshot detection trigger #4145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lfkellogg
merged 11 commits into
fad/in-app-feedback
from
lk/wait-for-pending-screenshots
Sep 27, 2022
Merged
Some fixes to the test app's screenshot detection trigger #4145
lfkellogg
merged 11 commits into
fad/in-app-feedback
from
lk/wait-for-pending-screenshots
Sep 27, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report 1Affected ProductsNo changes between base commit (fe657de) and merge commit (849c20b).Test Logs |
Size Report 1Affected Products
Test Logs |
kaibolay
approved these changes
Sep 26, 2022
Base automatically changed from
lk/screenshot-trigger
to
fad/in-app-feedback
September 27, 2022 12:55
I resolved the merge conflict. Please check if I did it correctly and merge if I did - otherwise please accept my apologies. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SecurityException
for when we don't have access to the screenshot anymore