Skip to content

Hook screenshot trigger to test app menu #4151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2022
Merged

Hook screenshot trigger to test app menu #4151

merged 1 commit into from
Sep 28, 2022

Conversation

lfkellogg
Copy link
Contributor

Also:

  • Refactor screenshot trigger so it can be enabled application-wide, instead of per activity
  • Put a guard in place on URI-based startActivity() methods to prevent callers from starting feedback multiple times simultaneously

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 28, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from 78.16% (831385b) to 78.24% (da907c2) by +0.07%.

    FilenameBase (831385b)Merge (da907c2)Diff
    FirebaseAppDistributionImpl.java94.29%94.42%+0.14%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/9QgzLshJIz.html

@lfkellogg lfkellogg force-pushed the lk/hook-up-screenshot-to-menu branch from 7aef447 to 8a1441a Compare September 28, 2022 17:29
@lfkellogg lfkellogg requested a review from kaibolay September 28, 2022 17:30
Base automatically changed from lk/add-trigger-menu to fad/in-app-feedback September 28, 2022 17:36
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 28, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (831385b)Merge (da907c2)Diff
    aar154 kB154 kB+78 B (+0.1%)
    apk (release)2.01 MB2.01 MB+112 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6PZvs1jmwl.html

@lfkellogg lfkellogg force-pushed the lk/hook-up-screenshot-to-menu branch from 8a1441a to 0797c47 Compare September 28, 2022 17:39
kaibolay
kaibolay approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@kaibolay kaibolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! ❤️

@lfkellogg lfkellogg merged commit 70a483f into fad/in-app-feedback Sep 28, 2022
@lfkellogg lfkellogg deleted the lk/hook-up-screenshot-to-menu branch September 28, 2022 20:17
@firebase firebase locked and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaibolay kaibolay kaibolay approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfkellogg @google-oss-bot @kaibolay