Skip to content

Update sign in wording on the SDK #4168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2022
Merged

Update sign in wording on the SDK #4168

merged 2 commits into from
Oct 6, 2022

Conversation

tejasd
Copy link
Contributor

@tejasd tejasd commented Oct 4, 2022

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 4, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (b06f6e6) to 78.24% (53b0160) by ?.

    39 individual files with coverage change

    FilenameBase (b06f6e6)Merge (53b0160)Diff
    AabUpdater.java?98.68%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?93.75%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?66.67%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?1.89%?
    FeedbackSender.java?90.91%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?94.42%?
    FirebaseAppDistributionLifecycleNotifier.java?98.00%?
    FirebaseAppDistributionNotificationsManager.java?80.00%?
    FirebaseAppDistributionRegistrar.java?81.58%?
    FirebaseAppDistributionTesterApiClient.java?87.63%?
    HttpsUrlConnectionFactory.java?50.00%?
    ImageUtils.java?96.00%?
    InstallActivity.java?2.53%?
    LogWrapper.java?62.50%?
    NewReleaseFetcher.java?77.55%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?88.00%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?66.67%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?42.86%?
    TaskUtils.java?96.30%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?89.47%?
    TesterSignInManager.java?93.62%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskImpl.java?75.71%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5VIqR0HVBC.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 4, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (b06f6e6)Merge (53b0160)Diff
    aar154 kB154 kB+2 B (+0.0%)
    apk (aggressive)882 kB882 kB+16 B (+0.0%)
    apk (release)2.01 MB2.01 MB+16 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CWG5cWAHW8.html

@tejasd tejasd requested review from lfkellogg and kaibolay October 5, 2022 21:24
@tejasd tejasd merged commit 4d64675 into fad/in-app-feedback Oct 6, 2022
@tejasd tejasd deleted the td/in-app-feedback branch October 6, 2022 14:46
@firebase firebase locked and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaibolay kaibolay kaibolay approved these changes

@lfkellogg lfkellogg Awaiting requested review from lfkellogg

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tejasd @google-oss-bot @kaibolay