Skip to content

Small tweaks to notification feedback trigger #4169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2022
Merged

Small tweaks to notification feedback trigger #4169

merged 1 commit into from
Oct 4, 2022

Conversation

lfkellogg
Copy link
Contributor

  • Change notification importance/priority to LOW
  • Set requestPermissionLauncher to null in onDestroy instead of onPause
  • Don't show notification for TakeScreenshotAndTriggerFeedbackActivity
  • Automatically reformat entire file to make this PR unreadable...

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (cde0818) to 78.24% (674203a) by ?.

    39 individual files with coverage change

    FilenameBase (cde0818)Merge (674203a)Diff
    AabUpdater.java?98.68%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?93.75%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?66.67%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?1.89%?
    FeedbackSender.java?90.91%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?94.42%?
    FirebaseAppDistributionLifecycleNotifier.java?98.00%?
    FirebaseAppDistributionNotificationsManager.java?80.00%?
    FirebaseAppDistributionRegistrar.java?81.58%?
    FirebaseAppDistributionTesterApiClient.java?87.63%?
    HttpsUrlConnectionFactory.java?50.00%?
    ImageUtils.java?96.00%?
    InstallActivity.java?2.53%?
    LogWrapper.java?62.50%?
    NewReleaseFetcher.java?77.55%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?88.00%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?66.67%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?42.86%?
    TaskUtils.java?96.30%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?89.47%?
    TesterSignInManager.java?93.62%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskImpl.java?75.71%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zjA3MdPiIu.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (cde0818) and merge commit (674203a).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XfRx4ejdIG.html

@lfkellogg lfkellogg requested a review from kaibolay October 4, 2022 21:54
@kaibolay kaibolay merged commit 6ccfe1e into fad/in-app-feedback Oct 4, 2022
@kaibolay kaibolay deleted the lk/trigger-tweaks branch October 4, 2022 21:59
@firebase firebase locked and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaibolay kaibolay kaibolay approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfkellogg @google-oss-bot @kaibolay