Notifications: Ask permission upfront, show only one persistent notification #4179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of cancelling and showing a new one as Activities pause/resume.
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected ProductsNo changes between base commit (4d64675) and merge commit (24f44b1).Test Logs |
lfkellogg
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
This looks great and works well for our test app so I think we should submit this as is. That said I just want to call out that I think when we move this to the SDK we could combine initialize, requestPermission, and enable into one call, and maybe even remove disable:
initialize()needed to be called in theApplication.onCreate()so we'd be able to hook into theActivity.onCreate()using lifecycle callbacks. But that's not necessary anymore now that we're telling them to callrequestPermission()in theActivity.onCreate(). We can just combine the two.enable()can probably also be combined into the same method. Our test app wants the ability to toggle this on and off but I don't see that being super useful in a real app. They probably just want to either enable it or not when the app starts. Also if they're requesting the permission they probably just want to go ahead and enable it.- For the same reason, I think we can consider removing
disable()
...tribution-api/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistribution.java
Show resolved
Hide resolved
| * | ||
| * @param activity the [Activity] object | ||
| */ | ||
| @RequiresApi(Build.VERSION_CODES.TIRAMISU) |
...src/main/java/com/googletest/firebase/appdistribution/testapp/NotificationFeedbackTrigger.kt
Outdated
Show resolved
Hide resolved
Makes sense! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.