Skip to content

remove NO_CHANGE bug fixes #4181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2022
Merged

remove NO_CHANGE bug fixes #4181

merged 2 commits into from
Oct 13, 2022

Conversation

qdpham13
Copy link
Contributor

@qdpham13 qdpham13 commented Oct 6, 2022 •
edited
Loading

Revert NO_CHANGE bug fixes: #4181 (review). These fixes will be replaced with the changes proposed in go/realtime-rc-forward-compatibility.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 6, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-config

    Overall coverage changed from 80.00% (dffa923) to 79.84% (12db797) by -0.16%.

    FilenameBase (dffa923)Merge (12db797)Diff
    ConfigAutoFetch.java88.64%88.24%-0.40%
    ConfigFetchHandler.java96.82%96.69%-0.13%
    ConfigFetchHttpClient.java85.03%84.83%-0.21%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/cI4nooFh9K.html

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022 •
edited
Loading

Unit Test Results

1 223 tests   - 3   1 223 ✔️  - 3   2m 40s ⏱️ +19s
     62 suites ±0          0 💤 ±0 
     62 files   ±0          0 ❌ ±0 

Results for commit 977ea6f. ± Comparison against base commit dffa923.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 6, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-config

    TypeBase (dffa923)Merge (12db797)Diff
    aar83.4 kB83.0 kB-381 B (-0.5%)
    apk (aggressive)119 kB119 kB-224 B (-0.2%)
    apk (release)743 kB743 kB-288 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gVn5ckJgui.html

@qdpham13 qdpham13 requested a review from danasilver October 12, 2022 20:16
danasilver
danasilver approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@danasilver danasilver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking: This reverts #4066

@qdpham13 qdpham13 merged commit 166cb9c into realtime-rc-merge Oct 13, 2022
@qdpham13 qdpham13 deleted the revert-NO_CHANGE branch October 13, 2022 17:27
@firebase firebase locked and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danasilver danasilver danasilver approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qdpham13 @google-oss-bot @danasilver