Skip to content

Add InterruptionLevel to notification trigger API #4205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2022
Merged

Add InterruptionLevel to notification trigger API #4205

merged 3 commits into from
Oct 17, 2022

Conversation

lfkellogg
Copy link
Contributor

@lfkellogg lfkellogg commented Oct 14, 2022 •
edited
Loading

A proposed change on top of: #4183

@lfkellogg lfkellogg changed the title Add InterruptionLevel to API WIP - Add InterruptionLevel to API Oct 14, 2022
@lfkellogg lfkellogg force-pushed the lk/interruption-level branch from 8dc340d to 22cb0a4 Compare October 14, 2022 20:22
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 14, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from 77.74% (bfa8ca1) to 77.88% (fb384d2) by +0.14%.

    FilenameBase (bfa8ca1)Merge (fb384d2)Diff
    FirebaseAppDistributionNotificationsManager.java77.78%80.95%+3.17%

  • firebase-appdistribution-api

    Overall coverage changed from 53.60% (bfa8ca1) to 49.63% (fb384d2) by -3.97%.

    FilenameBase (bfa8ca1)Merge (fb384d2)Diff
    InterruptionLevel.java?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YskNIYH8Eh.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-appdistribution-api:
error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.showFeedbackNotification(CharSequence,com.google.firebase.appdistribution.InterruptionLevel) [AddedAbstractMethod]
error: Removed method com.google.firebase.appdistribution.FirebaseAppDistribution.showFeedbackNotification(CharSequence,int) [RemovedMethod]
error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.showFeedbackNotification(int,com.google.firebase.appdistribution.InterruptionLevel) [AddedAbstractMethod]
error: Removed method com.google.firebase.appdistribution.FirebaseAppDistribution.showFeedbackNotification(int,int) [RemovedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

1 similar comment
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-appdistribution-api:
error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.showFeedbackNotification(CharSequence,com.google.firebase.appdistribution.InterruptionLevel) [AddedAbstractMethod]
error: Removed method com.google.firebase.appdistribution.FirebaseAppDistribution.showFeedbackNotification(CharSequence,int) [RemovedMethod]
error: Added method com.google.firebase.appdistribution.FirebaseAppDistribution.showFeedbackNotification(int,com.google.firebase.appdistribution.InterruptionLevel) [AddedAbstractMethod]
error: Removed method com.google.firebase.appdistribution.FirebaseAppDistribution.showFeedbackNotification(int,int) [RemovedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 14, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (bfa8ca1)Merge (071747f)Diff
    aar159 kB159 kB-37 B (-0.0%)
    apk (release)2.01 MB2.01 MB+388 B (+0.0%)

  • firebase-appdistribution-api

    TypeBase (bfa8ca1)Merge (071747f)Diff
    aar14.9 kB15.8 kB+888 B (+6.0%)
    apk (release)689 kB689 kB+380 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TeKs3AQeUS.html

@lfkellogg lfkellogg changed the title WIP - Add InterruptionLevel to API Add InterruptionLevel to notification trigger API Oct 17, 2022
@lfkellogg lfkellogg force-pushed the lk/interruption-level branch from 475b137 to f041536 Compare October 17, 2022 13:16
@lfkellogg lfkellogg merged commit dd1967f into lk/notification-trigger-api Oct 17, 2022
@lfkellogg lfkellogg deleted the lk/interruption-level branch October 17, 2022 13:24
lfkellogg added a commit that referenced this pull request Oct 21, 2022
@lfkellogg
Notification trigger API (#4183)
644483e 
* Add notification default trigger to in-app feedback

* Address Kai's feedback

* Update api.txt

* Address some feedback

* Add InterruptionLevel to notification trigger API (#4205)

* Add InterruptionLevel to API

* Move interruption and priority levels to InterruptionLevel enum

* Mark interruptionLevel as @nonnull

* Add @StringRes annotation
@firebase firebase locked and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaibolay kaibolay kaibolay left review comments

@vkryachko vkryachko Awaiting requested review from vkryachko

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfkellogg @google-oss-bot @kaibolay