Skip to content

fix crash #4251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 27, 2022
Merged

fix crash #4251

merged 8 commits into from
Oct 27, 2022

Conversation

kaibolay
Copy link
Contributor

No description provided.

@kaibolay kaibolay requested a review from lfkellogg October 27, 2022 13:59
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from 77.63% (644483e) to 77.67% (6a019df) by +0.04%.

    FilenameBase (644483e)Merge (6a019df)Diff
    FeedbackActivity.java1.67%1.69%+0.03%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/41YG8YlbfF.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (644483e)Merge (6a019df)Diff
    aar142 kB142 kB-32 B (-0.0%)
    apk (aggressive)820 kB820 kB-12 B (-0.0%)
    apk (release)2.00 MB2.00 MB+68 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GtOcBcpSj8.html

lfkellogg
lfkellogg approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@lfkellogg lfkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but how does this fix a crash?

@kaibolay
Copy link
Contributor Author

LGTM but how does this fix a crash?

The Button can end up being an AppCompatButton and for some reason that gave me a runtime error even though AppCompatButton extends Button...

@kaibolay kaibolay merged commit 6c391a2 into fad/in-app-feedback Oct 27, 2022
@kaibolay kaibolay deleted the kb/feedback-action-ui branch October 27, 2022 15:29
lfkellogg pushed a commit that referenced this pull request Nov 21, 2022
@kaibolay @lfkellogg
fix crash (#4251)
cd96a44
@firebase firebase locked and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfkellogg lfkellogg lfkellogg approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaibolay @google-oss-bot @lfkellogg