Skip to content

Clean up shake detection trigger example #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

lfkellogg
Copy link
Contributor

Renames it to be more aligned with the other triggers, adds javadocs, and reformats the file.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@kaibolay
Copy link
Contributor

Shouldn't this be merged info fad/in-app-feedback?

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 27, 2022

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (d87df66) to 77.68% (12437e1) by ?.

    40 individual files with coverage change

    FilenameBase (d87df66)Merge (12437e1)Diff
    AabUpdater.java?98.68%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?93.75%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?66.67%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?1.69%?
    FeedbackSender.java?90.91%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?91.92%?
    FirebaseAppDistributionLifecycleNotifier.java?96.67%?
    FirebaseAppDistributionNotificationsManager.java?80.95%?
    FirebaseAppDistributionRegistrar.java?82.05%?
    FirebaseAppDistributionTesterApiClient.java?87.63%?
    HttpsUrlConnectionFactory.java?50.00%?
    ImageUtils.java?100.00%?
    InstallActivity.java?2.53%?
    LogWrapper.java?68.75%?
    NewReleaseFetcher.java?77.55%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?88.00%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?62.16%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?42.86%?
    TakeScreenshotAndStartFeedbackActivity.java?0.00%?
    TaskUtils.java?96.30%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?89.47%?
    TesterSignInManager.java?93.62%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskImpl.java?75.71%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0lmS8tk8DV.html

Base automatically changed from lk/merge-fad-next-into-iaf to fad/in-app-feedback October 27, 2022 21:25
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 27, 2022

Size Report 1

Affected Products

  • base

    TypeBase (d87df66)Merge (12437e1)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)
  • firebase-annotations

    TypeBase (d87df66)Merge (12437e1)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.89 kB? (?)
  • firebase-appdistribution

    TypeBase (d87df66)Merge (12437e1)Diff
    aar?142 kB? (?)
    apk (aggressive)?820 kB? (?)
    apk (release)?2.00 MB? (?)
  • firebase-appdistribution-api

    TypeBase (d87df66)Merge (12437e1)Diff
    aar?15.9 kB? (?)
    apk (aggressive)?85.8 kB? (?)
    apk (release)?689 kB? (?)
  • firebase-common

    TypeBase (d87df66)Merge (12437e1)Diff
    aar?50.1 kB? (?)
    apk (aggressive)?85.1 kB? (?)
    apk (release)?683 kB? (?)
  • firebase-components

    TypeBase (d87df66)Merge (12437e1)Diff
    aar?42.8 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?31.9 kB? (?)
  • firebase-installations

    TypeBase (d87df66)Merge (12437e1)Diff
    aar?54.9 kB? (?)
    apk (aggressive)?86.5 kB? (?)
    apk (release)?706 kB? (?)
  • firebase-installations-interop

    TypeBase (d87df66)Merge (12437e1)Diff
    aar?8.05 kB? (?)
    apk (aggressive)?65.0 kB? (?)
    apk (release)?651 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/SoyHPVq0m2.html

@lfkellogg lfkellogg merged commit 78fbf7e into fad/in-app-feedback Oct 28, 2022
@lfkellogg lfkellogg deleted the lk/shake-cleanup branch October 28, 2022 12:49
@firebase firebase locked and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants